question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change permission UI on Desktop to enable / expose "permission until X" ability

See original GitHub issue

Description

This issue is follow up work for https://github.com/brave/brave-browser/issues/14126

This issue is specifically to track the design and implementation of UI for desktop Brave, to enable / expose the new capabilities defined in https://github.com/brave/brave-browser/issues/14126

The current (from upstream / default Chromium) UI currently looks like this: Screen Shot 2021-02-11 at 8 19 15 PM

Design

image

Dropdown options:

  • until I close this page (default selection)
  • for 24 hours
  • for 1 week
  • forever

Links:

  • “Site permissions” links to brave://settings/content.
  • “Learn more” links to post covering site permissions (to be written)

Assets

Figma: https://www.figma.com/file/pVwKlNQJU9wTVOa9tImKpo/Browser-Dialogs?node-id=26%3A51 Use button component: https://www.figma.com/file/z9wmg2FCwuXx9FLbDo5avJ/Platform-UI-Brave-desktop?node-id=1011%3A0 Use link component: https://www.figma.com/file/z9wmg2FCwuXx9FLbDo5avJ/Platform-UI-Brave-desktop?node-id=766%3A9370

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:26 (12 by maintainers)

github_iconTop GitHub Comments

3reactions
karenkliucommented, Apr 2, 2021

To clarify, the UX is in-line, the UI is not 😆 . It works as designed, but the buttons/dropdowns don’t look like what’s in our style guide. There will be a separate effort to clean that up!

I don’t see any issues with carrying over this permissions control dialog to other platforms.

2reactions
stephendonnercommented, Mar 10, 2021

Setting to QA/Blocked for now until we have both a test plan as well as all the necessary landings, before we can (fully) test; I’ve pinged @goodov in #brave-core on Slack for further clarification - if it’s ready, please feel free to remove that and let us know! Thanks!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Request app permissions - Android Developers
To do this, use the RequestPermission contract, included in an AndroidX library, where you allow the system to manage the permission request code...
Read more >
Change app permissions on your Android phone
It can use the permission until you're done with the app. Don't allow: The app cannot use the setting, even when you're using...
Read more >
System.Security.Permissions Namespace - Microsoft Learn
Defines classes that control access to operations and resources based on policy.
Read more >
Android permissions for system developers
INTERNET permission you can list all apps that are allowed to use APIs that can ... If no protection level is set, the...
Read more >
Quick Start Guide and sign in - Docker Documentation
Once Docker Desktop is installed, the Quick Start Guide launches. It includes a simple exercise to build an example Docker image, run it...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found