Change permission UI on Desktop to enable / expose "permission until X" ability
See original GitHub issueDescription
This issue is follow up work for https://github.com/brave/brave-browser/issues/14126
This issue is specifically to track the design and implementation of UI for desktop Brave, to enable / expose the new capabilities defined in https://github.com/brave/brave-browser/issues/14126
The current (from upstream / default Chromium) UI currently looks like this:
Design
Dropdown options:
- until I close this page (default selection)
- for 24 hours
- for 1 week
- forever
Links:
- “Site permissions” links to
brave://settings/content
. - “Learn more” links to post covering site permissions (to be written)
Assets
Figma: https://www.figma.com/file/pVwKlNQJU9wTVOa9tImKpo/Browser-Dialogs?node-id=26%3A51 Use button component: https://www.figma.com/file/z9wmg2FCwuXx9FLbDo5avJ/Platform-UI-Brave-desktop?node-id=1011%3A0 Use link component: https://www.figma.com/file/z9wmg2FCwuXx9FLbDo5avJ/Platform-UI-Brave-desktop?node-id=766%3A9370
Issue Analytics
- State:
- Created 3 years ago
- Comments:26 (12 by maintainers)
Top Results From Across the Web
Request app permissions - Android Developers
To do this, use the RequestPermission contract, included in an AndroidX library, where you allow the system to manage the permission request code...
Read more >Change app permissions on your Android phone
It can use the permission until you're done with the app. Don't allow: The app cannot use the setting, even when you're using...
Read more >System.Security.Permissions Namespace - Microsoft Learn
Defines classes that control access to operations and resources based on policy.
Read more >Android permissions for system developers
INTERNET permission you can list all apps that are allowed to use APIs that can ... If no protection level is set, the...
Read more >Quick Start Guide and sign in - Docker Documentation
Once Docker Desktop is installed, the Quick Start Guide launches. It includes a simple exercise to build an example Docker image, run it...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
To clarify, the UX is in-line, the UI is not 😆 . It works as designed, but the buttons/dropdowns don’t look like what’s in our style guide. There will be a separate effort to clean that up!
I don’t see any issues with carrying over this permissions control dialog to other platforms.
Setting to
QA/Blocked
for now until we have both a test plan as well as all the necessary landings, before we can (fully) test; I’ve pinged @goodov in #brave-core on Slack for further clarification - if it’s ready, please feel free to remove that and let us know! Thanks!