question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Channel name doesn't have channel string in `chrome://settings/help`

See original GitHub issue

Test plan

  1. Be on beta / dev / nightly (with 0.66.x or newer) on macOS
  2. Visit chrome://settings/help
  3. Verify channel name shows next to version. For example: image

Description

Screen Shot 2019-06-07 at 09 41 47

/Applications/Brave\ Browser\ Nightly.app/Contents/Info.plist doesn’t have KSChannelID key.

It is set by brave_app_list target in brave/BUILD.gn and only channel key is omitted. Others are set properly. This could cause many side-effect because of wrong channel.

brave_tweak_info_plist("brave_app_plist") {
    info_plist = "$root_gen_dir/chrome/chrome_app_plist_tweaked.plist"

    args = [
      "--brave_channel=" + brave_channel,
      "--brave_product_dir_name=" + brave_product_dir_name,
      "--brave_feed_url=" + brave_feed_url,
      "--brave_dsa_file=" + brave_dsa_file,
    ]

    deps = [
      "//chrome:chrome_app_plist",
    ]
  }

Only reproduced in nightly channel for now. I think the reason why this only happens in nightly is other channels are not yet release after we bumped cr version.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:9 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
bscliftoncommented, Jun 13, 2019

Removed verification labels - since we’ll have a 0.65.x hotfix (Chromium version) we can re-verify the fixes with an RC 😄

0reactions
btlechowskicommented, Jun 14, 2019

Moving back to 0.66.x as it is beta/dev/nighly only issue.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Set Chrome policies for users or browsers - Google Support
Enrolled browsers to enforce policies when users open Chrome browser on managed Microsoft Windows, Apple Mac, or Linux computers. Signing in is not...
Read more >
How to Change User-Agents in Chrome, Edge, Safari & Firefox
3. Navigate to Develop > User-Agent. You can again select from a predefined list or enter custom user-agent string by choosing “Other…”
Read more >
Google Chrome Privacy Whitepaper
Google Update requests include information necessary for the update process, such as the version of Chrome, its release channel, basic hardware ...
Read more >
Create and Manage Notification Channels - Android Developers
Read notification channel settings; Open the notification channel settings ... Though you can still change a channel's name and description.
Read more >
Common errors | Content API for Shopping - Google Developers
Summary, Invalid channel provided as part of a product ID. ... Summary, The item you tried to get, update or delete doesn't exist....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found