Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"chrome://" still being displayed when editing URL bar

See original GitHub issue

Description

When editing the URL bar, you’ll still be able to see the chrome:// protocol handler rather than the brave://

Steps to Reproduce

open either dev or beta
visit brave://settings and start editing the URL once the page loads

Actual result:

urlprotocal

Expected result:

Shouldn’t be displaying the chrome:// protocol handler when editing the URL box.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave	0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Mac OS X

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds?

Yes, currently reproducible on both dev and beta builds:

Brave	0.56.4 Chromium: 70.0.3538.54 (Official Build) dev (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Mac OS X

Brave	0.56.4 Chromium: 70.0.3538.54 (Official Build) dev (64-bit)
Revision	4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS	Mac OS X

Issue Analytics

State:
Created 5 years ago
Reactions:3
Comments:6 (5 by maintainers)

Top GitHub Comments

3reactions

fmariercommented, Dec 12, 2018

This will be fixed by https://github.com/brave/brave-core/pull/1074.

0reactions

bscliftoncommented, Jul 9, 2019

~Re-opening as this fix was reverted~ edit: whoops; this WAS fixed- got the wrong issue; meant to grab https://github.com/brave/brave-browser/issues/1973