Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Class/id cosmetic selectors intermittently missed

See original GitHub issue

Cosmetic filtering uses a hidden_class_id_selectors routine to query for CSS to inject based on the classes of elements newly added to the page or modified, using an in-page MutationObserver. That applies to generic cosmetic rules that can be queried by a particular class or id selector that must appear in the page; i.e. rules of the form ##.class-selector or ###id-selector.

We’ve noticed a handful of instances where rules of this form fail to be applied to pages. @ryanbr has been manually adding workarounds for these rules, of the form e.g. ##div.class-selector, which tricks Brave’s adblock engine into injecting these rules into all pages rather than finding them during MutationObserver queries. But this is not ideal, and we should discover and fix the root cause.

Issue Analytics

State:
Created a year ago
Comments:6

Top GitHub Comments

1reaction

GeetaSarvadnyacommented, Nov 29, 2022

Verification PASSED on

Brave | 1.46.129 Chromium: 108.0.5359.48 (Official Build) (64-bit)
-- | --
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS | Windows 10 Version 21H2 (Build 19044.2251)

Used a clean profile on 1.45.127 and STR from https://github.com/brave/brave-core/pull/15930#issue-1447010515 to view the cookie consent banner on initial load of https://websummit.com/. Note, these steps reproduce intermittently, so you may not have any luck.

Used a clean profile on 1.47.x and STR from https://github.com/brave/brave-core/pull/15930#issue-1447010515 and confirmed there was no cookie consent banner on initial load of https://websummit.com/. Refreshed (normal and hard refresh) several times, confirmed no cookie consent banner.

1.45.127	1.46.x

0reactions

Uni-versecommented, Dec 1, 2022

Verified on Samsung Galaxy S21 using the following build(s):

Brave	1.46.133 Chromium: 108.0.5359.71 (Official Build) (64-bit) 
Revision	1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS	Android 12; Build/SP1A.210812.016

Acceptance Criteria: https://github.com/brave/brave-browser/issues/26492#issuecomment-1301619849

Created a follow up issue regarding the cookie consent banner: https://github.com/brave/brave-browser/issues/27098