question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

cookies not imported - follow up to 1545

See original GitHub issue

Description

Follow up to #1545

Using --upgrade-from-muon argument, cookies are not being manually imported.

Steps to Reproduce

  1. Have an install of browser-laptop setup and configured (Release channel) with
    • bookmarks
    • history
    • cookies
    • saved passwords
  2. Download/install the brave-core release candidate
  3. Delete the brave-core profile (if one was created; sometimes installer will launch Brave after install)
  4. Launch brave-core via CLI and make sure to pass --upgrade-from-muon
  5. If prompted on macOS, allow access to your keychain.
  6. See that cookies are not imported but bookmarks, history, passwords are.
  7. Close b-c
  8. Launch brave-core via CLI and make sure to pass --upgrade-from-muon
  9. Cookies still not imported.
  10. Attempt to manually import Cookies (on macOS, Brave > Import Bookmarks and Settings > choose Brave from drop list and only select cookies in the list). Allow keychain access if requested. Cookies are manually imported.

Actual result:

Cookies are not imported with --upgrade-from-muon

Expected result:

Cookies should be imported with --upgrade-from-muon

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Reproduced on Windows by @srirambv and @btlechowski cc @garrettr @bsclifton

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
darkdhcommented, Nov 10, 2018

yeah, but for our importer hack, it cannot be initialized

0reactions
LaurenWagscommented, Nov 19, 2018

Verified passed on

Brave 0.56.14 Chromium: 70.0.3538.102 (Official Build) (64-bit)
Revision 4bbeebac88fdc09c97265e47c205868bbd190497-refs/branch-heads/3538@{#1077}
OS Mac OS X

Verification Passed on

Brave 0.56.14 Chromium: 70.0.3538.102 (Official Build) (64-bit)
Revision 4bbeebac88fdc09c97265e47c205868bbd190497-refs/branch-heads/3538@{#1077}
OS Windows
Read more comments on GitHub >

github_iconTop Results From Across the Web

react-cookie unable to set expires or maxAge - Stack Overflow
It seems that Cookies from react-cookie has been moved to the universal-cookie package. So the following should work: import Cookies from ...
Read more >
[BUG] Default search engine setting resets after update #1077
Description If you set a default search engine different from google, after Brave browser updates it resets this setting to google.
Read more >
I cannot import cookies to main list - WordPress.org
After cookie scan, i'm trying to merge Cookie List to the cookies found after the procedure but sadly i receive this error: “Unable...
Read more >
"SHOW EVENTS" fails with "Error Code: 1545. Failed to open ...
Firstly, get the mysql.event table working. (Consider it working if SELECT * from mysql.event works). Try these in this order (check after each...
Read more >
Dealing With Difficult Data - ISACA
Device control characters such as tabs and line feed may cause interpretation issues during import for other file types, not just Excel.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found