Correct the text for Request ads enable popup
See original GitHub issue"Click anywhere on the screen to continue to Brave Talk."
This excludes non-mouse users. Can we have it auto dismiss and perhaps just remove this line?
"By clicking, you agree to the Terms of Service and Privacy Policy. Disable any time in Settings."
Perhaps instead of “clicking” we can use a more inclusive term more specific to the action? Android request ads enable popups also has the text, that includes “click” keyword. Should we change the text?
The popups texts change was requested here: https://github.com/brave/brave-core/pull/9611#discussion_r718603843 and here: https://github.com/brave/brave-core/pull/9611#discussion_r718604602
Issue Analytics
- State:
- Created 2 years ago
- Comments:6
Top Results From Across the Web
Allow or block pop-ups in Safari on Mac - Apple Support
In Safari on your Mac, block pop-up windows from websites.
Read more >Block or allow pop-ups in Chrome - Android - Google Support
Allow pop -ups from a specific site · On your Android phone or tablet, open the Chrome app Chrome . · Go to...
Read more >Handle pop-ups, permissions, and notifications - BrowserStack
Learn how to manage pop-ups, permissions, and notifications in different browsers when running your Selenium tests on BrowserStack Automate. Introduction. When ...
Read more >Creating a promotional pop-up - Squarespace Help Center
Customize the pop-up's text, timing, and appearance using the Action, Content, Display & timing, Image, and Style settings.
Read more >Instructions for Disabling Pop-up Blockers on commonly used ...
Click the Settings button to disable pop-up blockers for specific sites. ... Click the Firefox menu in the right hand corner of the...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Thanks, @tmancey — here’s a couple strings that I think could work:
[We can use that second string for both ads & rewards button disclaimers. It’s generalized enough.]
Hope this helps. LMK if I can provide anything else.
Verified
PASSED
using Brave1.33.37, Chromium 95.0.4638.54
on a Google Pixel XL, Android 9.Steps:
--enable-features=RequestAdsEnabledApi
talk.brave.com
Start free 1:1 call
Turn on Rewards
dialog textTurn on Rewards
You can now start a free call
popup textbrave://rewards/
and toggledAds
toOff
talk.brave.com
Start free 1:1 call
Turn on Brave Private Ads
dialog textTurn on Brave Private Ads
You can now turn make a free call
dialog textConfirmed:
clicking
->enabling
click
->click or tap
Disable any time in Settings