question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Correct the text for Request ads enable popup

See original GitHub issue
  1. "Click anywhere on the screen to continue to Brave Talk."

This excludes non-mouse users. Can we have it auto dismiss and perhaps just remove this line?

  1. "By clicking, you agree to the Terms of Service and Privacy Policy. Disable any time in Settings."

Perhaps instead of “clicking” we can use a more inclusive term more specific to the action? Android request ads enable popups also has the text, that includes “click” keyword. Should we change the text?

The popups texts change was requested here: https://github.com/brave/brave-core/pull/9611#discussion_r718603843 and here: https://github.com/brave/brave-core/pull/9611#discussion_r718604602

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6

github_iconTop GitHub Comments

1reaction
rmcfadden3commented, Oct 13, 2021

Thanks, @tmancey — here’s a couple strings that I think could work:

  • “Click or tap anywhere on the screen to continue to Brave Talk.”
  • “By enabling, you agree to the Terms of Service and Privacy Policy.”

[We can use that second string for both ads & rewards button disclaimers. It’s generalized enough.]

Hope this helps. LMK if I can provide anything else.

0reactions
stephendonnercommented, Oct 27, 2021

Verified PASSED using Brave 1.33.37, Chromium 95.0.4638.54 on a Google Pixel XL, Android 9.

Steps:

  1. new profile
  2. launched Brave using --enable-features=RequestAdsEnabledApi
  3. loaded talk.brave.com
  4. tapped Start free 1:1 call
  5. read the Turn on Rewards dialog text
  6. tapped on Turn on Rewards
  7. read the You can now start a free call popup text
  8. went to brave://rewards/ and toggled Ads to Off
  9. loaded talk.brave.com
  10. tapped Start free 1:1 call
  11. read the Turn on Brave Private Ads dialog text
  12. tapped on Turn on Brave Private Ads
  13. read the You can now turn make a free call dialog text

Confirmed:

  • clicking -> enabling
  • click -> click or tap
  • removed Disable any time in Settings
example example example example
Screenshot_20211027-101330 Screenshot_20211027-101406 Screenshot_20211027-101428 Screenshot_20211027-102413
Read more comments on GitHub >

github_iconTop Results From Across the Web

Allow or block pop-ups in Safari on Mac - Apple Support
In Safari on your Mac, block pop-up windows from websites.
Read more >
Block or allow pop-ups in Chrome - Android - Google Support
Allow pop -ups from a specific site · On your Android phone or tablet, open the Chrome app Chrome . · Go to...
Read more >
Handle pop-ups, permissions, and notifications - BrowserStack
Learn how to manage pop-ups, permissions, and notifications in different browsers when running your Selenium tests on BrowserStack Automate. Introduction. When ...
Read more >
Creating a promotional pop-up - Squarespace Help Center
Customize the pop-up's text, timing, and appearance using the Action, Content, Display & timing, Image, and Style settings.
Read more >
Instructions for Disabling Pop-up Blockers on commonly used ...
Click the Settings button to disable pop-up blockers for specific sites. ... Click the Firefox menu in the right hand corner of the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found