Crash when clicking on the Brave or Brave Rewards icons with `extensions-toolbar-menu` enabled

Test plan

See https://github.com/brave/brave-core/pull/4065

Description

Brave crashes whenever I click on the Brave or Brave Rewards icons on the address bar. brave://crashes is empty.

Steps to Reproduce

1. Open Brave
2. Click on the Brave or Brave Rewards icon

Actual result:

Brave crashes

Expected result:

Brave should not crash. The proper dialog (either the Shields dialog or the Brave Rewards dialog, depending on which icon was clicked) should show up.

Reproduces how often:

Happens every time

Brave version (brave://version info)

Brave: 0.67.124 Chromium: 76.0.3809.100 (Official Build) (64-bit) Revision: ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990} OS: Linux Window manager: KDE Plasma 5.16.4-0ubuntu1

$ lsb_release -a
LSB Version:    core-10.2019031300ubuntu1-noarch:printing-10.2019031300ubuntu1-noarch:security-10.2019031300ubuntu1-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 19.04
Release:        19.04
Codename:       disco
You                                                                                                                                                            

$ uname -a
Linux tumbolia 5.0.0-23-generic #24-Ubuntu SMP Mon Jul 29 15:36:44 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Version/Channel Information:

I have not tried it on any other channels. However, it happened on the previous version I got from the https://brave-browser-apt-release.s3.brave.com PPA, possibly on even earlier versions, but I haven’t been keeping track of how often it is updated. It has been happening for a few weeks now.

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?

I cannot disable Brave Shields due to this issue

• Does the issue resolve itself when disabling Brave Rewards?

I cannot disable Brave Rewards due to this issue

• Is the issue reproducible on the latest version of Chrome?

Does not apply to Chrome, this is Brave-specific functionality

Miscellaneous Information:

[Brave-Matt]

I can confirm and reproduce that, when the #extensions-toolbar-menu flag is enabled, attempting to access either Shields or Rewards via icon in address bar will crash the browser. I have a +1 here and will drop in others i’ve seen: https://community.brave.com/t/pressing-the-shield-button-crashes-brave/81943/3

[btlechowski]

Verification passed on

Brave	1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/4065 Tested on Brave Shields button and Rewards button.

Verification passed on

Brave	1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from https://github.com/brave/brave-core/pull/4065
• Verified both clean and upgraded profile
• Verified there is no crash when tested Shield/Rewards/Crypto wallet/Multiple profiles/Open diff tab types etc…

Verified passed with

Brave	1.3.86 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	macOS Version 10.14.6 (Build 18G103)

• Reproduced issue with 1.2.42 (Release Channel)
• Verified test plan from https://github.com/brave/brave-core/pull/4065
• Verified on clean and upgrade profiles
• Verified for both Shields and Rewards icons