Crash while using omnibox in Tor window with an enabled extension

STR:

1. Install DDG privacy essentials https://chrome.google.com/webstore/detail/duckduckgo-privacy-essent/bkdgflcldnnnapblkhphbgpggdiikppg?hl=en
2. on brave://extensions/?id=bkdgflcldnnnapblkhphbgpggdiikppg enable “Allow in private”
3. Open TOR window
4. focus omnibox and type
5. crash

Mac OS:

[ 00 ] <name omitted>
[ 01 ] non-virtual thunk to TorWindowSearchEngineProviderService::OnTemplateURLServiceChanged()
[ 02 ] TemplateURLService::Scoper::~Scoper()
[ 03 ] TemplateURLService::OnWebDataServiceRequestDone(int, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >)
[ 04 ] WebDataRequestManager::RequestCompletedOnThread(std::__1::unique_ptr<WebDataRequest, std::__1::default_delete<WebDataRequest> >, std::__1::unique_ptr<WDTypedResult, std::__1::default_delete<WDTypedResult> >)

Windows:

[ 00 ] PrefMember<int>::UpdatePref(int const &)
[ 01 ] TorWindowSearchEngineProviderService::OnTemplateURLServiceChanged()
[ 02 ] base::ObserverList<AccessContextAuditService::CookieAccessHelper,0,1,base::internal::CheckedObserverAdapter>::begin()
[ 03 ] base::internal::PartitionFree(base::allocator::AllocatorDispatch const *,void *,void *)
[ 04 ] TemplateURLService::Scoper::~Scoper()
[ 05 ] TemplateURLService::OnWebDataServiceRequestDone(int,std::__1::unique_ptr<WDTypedResult,std::__1::default_delete<WDTypedResult> >)
[ 06 ] WebDataRequestManager::RequestCompletedOnThread(std::__1::unique_ptr<WebDataRequest,std::__1::default_delete<WebDataRequest> >,std::__1::unique_ptr<WDTypedResult,std::__1::default_delete<WDTypedResult> >)
[ 07 ] _tailMerge_esent.dll
[ 08 ] _tailMerge_esent.dll
[ 09 ] base::internal::Invoker<base::internal::BindState<void (WebDataRequestManager::*)(std::unique_ptr<WebDataRequest,std::default_delete<WebDataRequest> >, std::unique_ptr<WDTypedResult,std::default_delete<WDTypedResult> >),scoped_refptr<WebDataRequestManager>,std::unique_ptr<WebDataRequest,std::default_delete<WebDataRequest> >,std::unique_ptr<WDTypedResult,std::default_delete<WDTypedResult> > >,void ()>::RunOnce
[ 10 ] base::ThreadLocalStorage::Slot::Get()
[ 11 ] base::TaskAnnotator::RunTask(char const *,base::PendingTask *)
[ 12 ] WebDataRequestManager::RequestCompleted(std::__1::unique_ptr<WebDataRequest,std::__1::default_delete<WebDataRequest> >,std::__1::unique_ptr<WDTypedResult,std::__1::default_delete<WDTypedResult> >)
[ 13 ] KeywordWebDataService::GetKeywords(WebDataServiceConsumer *)
[ 14 ] _tailMerge_esent.dll
[ 15 ] WebDataRequestManager::RequestCompleted(std::__1::unique_ptr<WebDataRequest,std::__1::default_delete<WebDataRequest> >,std::__1::unique_ptr<WDTypedResult,std::__1::default_delete<WDTypedResult> >)

https://brave.sp.backtrace.io/p/brave/explore?time=month&filters=((callstack.functions%2Ccontains%2COnTemplateURLServiceChanged)%2C_deleted%3D0%2C(ver%2Cregex%2C"89|90.*")%2Cptype%3Dbrowser)&aggregations=((uname.sysname%2Cdistribution%2C3)%2C(ver%2Cmax)%2C(callstack%2Chead))&

[kjozwiak]

Sorry, jumped the gun a bit and did actually crash, as per #15140 (comment) - restoring all the correct labels, and removing my erroneous “verification” (boo).

@StephenBass we never ended up getting https://github.com/brave/brave-browser/issues/15224 into 1.23.x as @simonhong is still investigating/working on it. He mentioned that the fix wouldn’t be easy and would most likely not make it into 1.23.x. That was when we were supposed to release tomorrow till C89 threw a ranch into the release schedule. Plus, https://github.com/brave/brave-browser/issues/15224 is also reproducible on 1.22.x as per https://github.com/brave/brave-browser/issues/15224#issuecomment-818478361.

So we can QA what we have so far re: not crashing when focusing/typing into the omnibox. You can re-add your verification 👍 Apologies, should have update the issue earlier.

[LaurenWags]

Adding QA/Blocked until a new RC is built