Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Custom notifications are shown when native(system) notifications are enabled

See original GitHub issue

native(system) notifications must be used when native(system) notifications are enabled and For Windows 10 build 17134 and newer (should not be shown if Focus Assist is enabled) For macOS 10.14 and newer if native notifications are enabled For Android 8 and newer

More info https://github.com/brave/brave-variations/pull/120

Steps to Reproduce

Enable native(system) notifications
Run Brave with --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --variations-server-url=https://variations.bravesoftware.com/seed
Restart Brave
Make sure variations are downloaded in brave://version
Enable rewards and ads
Trigger an ad

Actual result:

Custom notification is shown

Expected result:

native(system) notifications is shown

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.30.84 Chromium: 94.0.4606.54 (Official Build) (64-bit)
Revision	c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS	Windows 10 Version 20H2 (Build 19042.1237)

cc @brave/legacy_qa @rebron @tmancey @jsecretan

Issue Analytics

State:
Created 2 years ago
Reactions:2
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

kjozwiakcommented, Sep 27, 2021

Once we get RC builds, we should quickly run through https://github.com/brave/brave-variations/pull/129 to make sure things are working as expected. There’s some notes/better STR/Cases outlined via https://github.com/brave/brave-variations/pull/120 which is the same PR but merged into main (staging).

1reaction

kjozwiakcommented, Sep 24, 2021

As @btlechowski mentioned, this is also reproducible on macOS 11.5.2 x64 as well. Even though you have system notifications enabled via Notifications under System Notifications, you’re always going to get added into the following and you’ll get custom ad notifications 100% of the time even though native notifications should be shown/used:

[9007:259:0924/120415.982593:VERBOSE1:features.cc(45)] Study BraveAds.ShowCustomAdNotificationOnMacStudy is active (Enabled)

This is in relation to https://github.com/brave/brave-variations/pull/120. Specifically:

Native ad notifications should be displayed via the following when:

for macOS 10.14 and newer if native notifications are enabled - seeing custom ad notifications
for Windows 10 build 17134 and newer (should not be shown if Focus Assist is enabled) - seeing custom ad notifications

Top Results From Across the Web

Customizing the Appearance of Notifications - Apple Developer

Customize the appearance of your iOS app's notification alerts with a notification content app extension.

Create a Custom Notification Layout | Android Developers

If you need a custom layout, you can apply NotificationCompat.DecoratedCustomViewStyle to your notification. This API allows you to provide a ...

How to enable native Chrome notifications on Windows 10

How to manage Chrome native notifications · Open Settings. · Click on System. · Click on Notifications. · Under “Get notifications from these ......

Change your notifications style in Teams - Microsoft Support

Change your Teams notifications style to Windows 10 native notifications. ... top left of your Mac device, and select System Preferences > Notifications....

Notifications - Expo Documentation

For Bare react native apps, see Customize Notification Icons to manually ... It lets you verify whether the app is currently allowed to...