Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Desktop :: Implement "Enabling Sites to Determine Brave" Spec

See original GitHub issue

Description

Please implement the “Enabling Sites to Determine Brave” Spec

Search for “Enabling Sites to Determine Brave” in G-Drive for the Spec (also described in below post) cc @snyderp

Android Link: https://github.com/brave/brave-browser/issues/8215 iOS Link: https://github.com/brave/brave-ios/issues/2323

Test plan

Visit https://jsbin.com/sexawix/edit?html,js,console
Output from console should look like:

"Brave detected"

Issue Analytics

State:
Created 4 years ago
Comments:26 (10 by maintainers)

Top GitHub Comments

2reactions

bridivercommented, Mar 19, 2020

@2b what is your specific concern? As @pes10k mentioned we are working on a lot of projects to make Brave users indistinguishable from other Brave users, but hiding the fact that you’re using Brave is very difficult because we are intentionally blocking some features that Chrome provides, among other things.

2reactions

da2xcommented, Feb 24, 2020

Thanks for calling out though, as these not matching may be an issue.

I just re-read the relevant parts of the spec. These should definitely be the same value.

I wasn’t aware we are supporting this header yet? Did you have to compile with kUserAgentClientHint added to the enabled features? (ex: in src/brave/app/brave_main_delegate.cc)

Just enable chrome://flags/#enable-experimental-web-platform-features and restart the browser.