Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Desktop] Suggestion: Restyle and implement inherited "tab groups" feature

See original GitHub issue

Description

It seems as though we’ve inherited Chrome’s experimental “tab groups” feature and that it works in Brave as well without issue (seemingly). The feature still sits be hind a flag (#tab-groups) right now and I think it would be advantageous to hijack this feature and make it our own.

Functionality

The way the feature is currently implemented:

Right-clicking on a tab gives you options to Add, Add to existing or Remove a tab to/from a group.

groups

You can also drag tabs into (or out of) pre-existing groups.

tabdrag

If you Ctrl/Cmd + Click a link on a tab already grouped, the link will open and be automatically added to that same tab group.

tabcmdclick

Clicking the tab group color gives you options for customizing that groups color and giving each group a name/title.

Optionally/additionally, we may want to consider re-implementing the tab “pages” feature in conjunction with this, the way we did in Muon. I’m personally a fan of Cliftons “slick animation” example.

Miscellaneous Information:

Implementing this would make many users happy – as it has been requested several times and in many different ways. These are just the ones I’ve pulled from Community in my initial search:

Issue Analytics

State:
Created 4 years ago
Reactions:32
Comments:15 (3 by maintainers)

Top GitHub Comments

13reactions

timelytreecommented, Feb 22, 2021

Tab groups have proven to be a very powerful and useful feature. Although functionally, they work well in Brave - visually as mentioned above, they’re quite unpleasant and I do find myself missing the zen beauty of Chrome’s UI implementation for them.

Actually this seems like it would be a pretty easy fix if we ever get something like a custom.css file as mentioned in https://github.com/brave/browser-laptop/issues/1122 (moved to #774).

Customization similar to Atom; a simple doc you can edit

Adding some screenshots for reference:

Brave: Screen Shot 2021-02-22 at 3 48 54 AM

Chrome: Screen Shot 2021-02-22 at 3 49 42 AM

7reactions

Sojiro84commented, Jan 9, 2021

After trying out the Chromium’s tab group feature with the sexy circular design and proper spacing vs Brave’s square design with improper spacing (especially where the name of the tab-group color collides with the tab itself), I really prefer Chromium’s version.

I hope you guys will fix the spacing. Right now it’s visually unpleasant and since I use tab groups a lot, I am back to using Chromium until this is fixed.