Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
do not show "Your wallet is verified!" message when reconnecting after natural disconnect
See original GitHub issueDescription
Per discussion in https://bravesoftware.slack.com/archives/CB0KCRCQN/p1627659102017500, we should not show the “Your wallet is verified!” message/notification when a user is reconnecting after natural disconnect.
Steps to Reproduce
- Clean profile 1.29.x, staging env
- Enable Rewards
- Link KYC’d, verified Uphold account
- Simulate “natural” disconnect by revoking Brave-Browser app authorization on Uphold site
- Confirm UI shows “Disconnected”/no balance
- Click on “Disconnected” and reauthorize Uphold
- You are successful in re-auth and you get this notification
Also reproduces in this scenario:
- Using current release version, 1.27.109, clean profile, staging env, enable Rewards, link KYC’d Uphold wallet
- Simulate “natural” disconnect by revoking Brave-Browser app authorization on Uphold site
- Close browser
- “Upgrade” (rename profile to
Brave-Browser-Nightly) to 1.29.x - Confirm your verified, KYC’d wallet is still in Disconnected status after upgrade (appropriate UI, no Uphold balance shown)
- Click on “Disconnected” and re-auth with Uphold
Actual result:
Your wallet is verified notification:
Expected result:
No notification in this case
Reproduces how often:
easily
Brave version (brave://version info)
| Brave | 1.29.40 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64) |
|---|---|
| Revision | 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4} |
| OS | macOS Version 11.5.1 (Build 20G80) |
Version/Channel Information:
- Can you reproduce this issue with the current release? n/a
- Can you reproduce this issue with the beta channel? n/a
- Can you reproduce this issue with the nightly channel? yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields?
- Does the issue resolve itself when disabling Brave Rewards?
- Is the issue reproducible on the latest version of Chrome?
Miscellaneous Information:
Issue Analytics
- State:
- Created 2 years ago
- Comments:6 (3 by maintainers)
Top Results From Across the Web
Wallet Address Not Confirmed - Coinmama Support
Coinmama will not send your coins until you have confirmed your wallet address by clicking the link in the wallet confirmation email you...
Read more >How to check if Metamask is connected after page refreshing
I finally found a possible solution and it turned out to be as simple as it should be. There is an eth_accounts method...
Read more >Electrum Documentation - Read the Docs
In short, not really. The Electrum client never sends private keys to the servers. In addition, it verifies the information.
Read more >Web3 Dapp Developer Guide: React Hooks for Ethereum
With Web3 Onboard's Ethereum react hooks, any developer can quickly set up their dapp to interact with the best web3 wallets.
Read more >ID document verification | Coinbase Help
ID verification is required to prevent fraud and keep the community safe. It also adds an extra layer of security by ensuring no...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
@GeetaSarvadnya That’s odd. Just took a look with
1.31.10and it was working fine. Let me rebase and try that again!Hey @GeetaSarvadnya! FYI: https://github.com/brave/brave-core/pull/9738 is not getting uplifted to
1.29.x.