Enable Brave VPN feature flag by default on Desktop

Description

Before we can go live with VPN, we need to enable the feature by default. It’s already live for iOS and Android

Currently, folks testing have to enable using brave://flags/#brave-vpn

We should enable VPN by default using Griffin (https://griffin.brave.com/)

Overall VPN Test plan

This area is a work in progress! It will continue to grow as we get closer to rollout

Pre-requisites

• Finish the Linking page (on accounts.brave.com) and deploy to all environments https://github.com/brave/account-brave-com/issues/24
• Push the Brave VPN SKU to Production (it’s already in dev and staging)
• Add the “Link account” button on Android https://github.com/brave/brave-browser/issues/21972
• Add the “Link account” button on iOS https://github.com/brave/brave-ios/issues/5175
• Website???

Desktop

NOTE: VPN only available on macOS and Windows

• Original Desktop test plan https://github.com/brave/brave-browser/issues/15804

1. VPN menu should show next to hamburger menu
2. Click the VPN button and it should show a promo
3. Click the promo and it should go to account.brave.com
4. Login to account.brave.com with a new account
5. Once signed in, click Plans on menu on left
6. Brave VPN should show as a product
7. Click Buy now for Brave VPN and complete checkout
8. You should now be able to click VPN menu (next to hamburger menu) and see a server list
9. Choose a server and connect
10. Verify you’re connected by visiting https://whatismyipaddress.com/
11. You can switch profiles and verify the other profiles can connect also

• What checks are needed for Linux? - See https://bravesoftware.slack.com/archives/CC5SA8CCB/p1669218929305149 for recent suggestions of what to cover.

Mobile

• Using in-app-purchase on iOS or Android and linking https://github.com/brave/account-brave-com/issues/24

iOS

• Buying on desktop and redeeming on iOS https://github.com/brave/brave-ios/issues/4805

Android

• Buying on desktop and redeeming on Android https://github.com/brave/brave-browser/issues/20374
• See test plan at https://github.com/brave/brave-core/pull/14715

Known issues with the VPN service itself

Brave employees should have access to https://github.com/brave/support-guardian-vpn/projects/1

[bsclifton]

Keeping this issue tied to 1.46. I do have a code change which enables this - but I think we’ll hold off

We can enable this on DESKTOP with Griffin

[LaurenWags]

Verification in progress with

Brave	1.46.134 Chromium: 108.0.5359.94 (Official Build) (arm64) 
Revision	713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS	macOS Version 12.6.1 (Build 21G217)

Security & privacy

DNS leak (ISP) - PASSED

1. connect to any region
2. load https://browserleaks.com/dns
3. confirm your local (ISP) DNS resolvers are not shown; they should be from the connected VPN region
4. disconnect from VPN
5. reload https://browserleaks.com/dns
6. confirm your local (ISP) DNS resolvers are shown

BraveVPN DNS resolvers	local ISP resolvers

DNS-over-HTTP (DoH) - PASSED

1. connect to VPN
2. enable DNS over HTTP using any provider, via brave://settings/security
3. load browserleaks.com/dns
4. confirm the provider’s resolvers are shown (NOT your local ISP’s)

brave://settings/security	browserleaks.com/dns

TOR - PASSED

1. connect to VPN
2. open a New Private window with Tor
3. load check.torproject.org
4. ensure you see Congratulations. This browser is configured to use Tor

Torrent (via WebTorrents support) - PASSED

1. run through the Shared VPN-Setup Steps section
2. disconnect from BraveVPN
3. load https://ipleak.net/
4. click on Activate under Torrent Address detection
5. opem this Magnet Link in a new window
6. may need to reload the URL (to work around a bug)
7. click on Start Torrent
8. return to the https://ipleak.net/ tab
9. confirm that you see your public (local ISP) IP address
10. connect to BraveVPN via your preferred method (flyout menu, button toggle, macOS system bar (top), and Network control panel in System Preferences)
11. shift + reload the page (to purge cache) <------ IMPORTANT
12. repeat steps 4-8
13. confirm you now see the appropriate VPN IP address (for your region)

step 9 - local ISP	step 13 - Germany

WebRTC - PASSED

1. connect to BraveVPN
2. load https://browserleaks.com/webrtc
3. iterate through the values for WebRTC IP handling policy
4. note the absence/presence and value of both local + public IP addresses, as reflected by their respective setting

VPN connected

Default	Default public and private interfaces	Default public interface only	Disable non-proxied UDP

Disconnected from VPN

Default	Default public and private interfaces	Default public interface only	Disable non-proxied UDP

Keyboard accessibility - PASSED

1. set up VPN
2. click on the VPN button on the browser toolbar
3. click on the Settings (gear) icon
4. press tab to forward-cycle through elements
5. press shift + tab to backwards-cycle through the dialog links
6. confirm you can press spacebar and return to select (“click”) links

Confirmed tab and shift + tab worked as per the above. Confirmed spacebar and return worked as per the above.