question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

eWEEK news page is Speedreader-enabled but probably shouldn't be

See original GitHub issue

Description

eWEEK news page is Speedreader-enabled but probably shouldn’t be

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load https://www.eweek.com/news/
  4. click on the Speedreader icon in the URL bar
  5. after it reloads, look at the resulting page

Actual result:

Speedreader enabled Speedreader disabled
Screen Shot 2021-09-20 at 2 11 43 PM Screen Shot 2021-09-20 at 2 11 48 PM

Expected result:

Not sure; the page doesn’t appear to be a good candidate for Speedreader, though. It looks pretty close, if not identical, to non-Speedreader

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.32.4 Chromium: 94.0.4606.50 (Official Build) nightly (x86_64)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS macOS Version 11.6 (Build 20G165)

/cc @keur

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
ryanbrcommented, Sep 21, 2021

Just to clean up the blank space on eweek. Landed: https://github.com/easylist/easylist/commit/1bf2a3c

1reaction
keurcommented, Sep 22, 2021

@stephendonner For the test plan just verify those two sites don’t show the icon any longer and this all works as expected. Some things to note:

  1. You will need to hard refresh on those sites that are being incorrectly shown as readable, since the browser cached that incorrect data. Once you do that it should never happen again.
  2. I added some regression tests for the icon. Should help for future rebases.
Read more comments on GitHub >

github_iconTop Results From Across the Web

I Was Wrong About Speed Reading (2015) - Hacker News
Reading speed strikes me similarly to typing speed when it comes to programming. It's fun to read/type fast, but it's not really the...
Read more >
Opinion | Sorry, You Can't Speed Read - The New York Times
Certainly, readers are capable of rapidly scanning a text to find a specific word or piece of information, or to pick up a...
Read more >
Free App - Spreeder
Speed reading is the art of silencing subvocalization. Most readers have an average reading speed of 200 wpm, which is about as fast...
Read more >
Why You Should Stop Reading News - Farnam Street
Reading the news doesn't make us informed, just the opposite. And our obsession with being informed makes it hard to think long term....
Read more >
News is bad for you – and giving up reading it will make you ...
News is bad for you. It leads to fear and aggression. It hinders your creativity and makes you sick. We should stop consuming...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found