question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix cosmetic filters not being applied inside of child frames

See original GitHub issue

Description

Some cosmetics aren’t being applied

Steps to Reproduce

  1. Enable Fanboy Annoyances in brave://adblock
  2. Open https://instapundit.com/513971/#respond
  3. Expect the social elements to be filtered.

Actual result:

21d1ffc267cdb12a53798e74e74b55b697953d47_2_690x469

Expected result:

Social cosmetics should be removed/filtered out.

Reproduces how often:

Easily, when Annoyances/Social list is enabled.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @antonok-edm

Related thread: https://community.brave.com/t/block-something-using-browser-instead-of-ublock-origin/368569/

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:2
  • Comments:15 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
mckealtycommented, Jul 6, 2022

@antonok-edm Ok sounds good! I would tip you some BAT but for some reason tip buttons have never shown up in my browser. If and when I figure it out I’ll send some your way. Thank you for the work you did on this!

0reactions
mckealtycommented, Oct 11, 2022

Awesome, thanks so much!

On Fri, Jul 1, 2022 at 7:31 PM Anton Lazarev @.***> wrote:

@mckealty https://github.com/mckealty It should be fixed in v1.42.50+; please feel free to follow up if you see any more issues 😃

— Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/22781#issuecomment-1172783505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZZ2CH77URTOBEBXWYQXQMTVR55WHANCNFSM5VUDOMTA . You are receiving this because you were mentioned.Message ID: @.***>

Read more comments on GitHub >

github_iconTop Results From Across the Web

What You Need to Know About Eyeglass Lens Coatings
No matter what your warranty says, if a coating starts to degrade within a year, Vitale recommends taking the glasses back to see...
Read more >
Canva: Using Filters on Images inside Frames - YouTube
In this video I'll show you how you can now add filters to images that you've placed inside a frame in Canva.❤️ Want...
Read more >
How to Fix a Lazy Eye: Treatment Strategies - Healthline
Surgical solutions for lazy eye usually require additional strategies, such as eye patching, in order to correct vision. Surgery is also used to ......
Read more >
Eyes and mouth filter tiktok - - Convittiadi Campobasso
Find a video that's used the filter. To Try Out the Crying Face Filter on Snapchat. 5M videos. The app asks for the...
Read more >
FAQ | Zenni Optical
The easiest way to find eligible frames is to use the filter tool and select ... (5-10 Business days) time frame do not...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found