Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Get Chromium browser_tests working

See original GitHub issue

Running npm run test -- browser_tests currently ends in a compiler error preventing any of the tests to run.

This means I can’t verify Chromium test are broken with other changes such as: https://github.com/brave/brave-browser/issues/8184

Issue Analytics

State:
Created 4 years ago
Comments:7 (4 by maintainers)

Top GitHub Comments

1reaction

jonathanKingstoncommented, Feb 19, 2020

@bsclifton it’s noisy certainly, however the --filter flag is useful for running certain tests. I ran the tests for roughly 4 hours. There are about 1k of tests that fail.

I’m hoping to chase down the following error lines:

[18421:18431:0219/015138.807643:ERROR:service_manager.cc(210)] Failed to resolve service name: bat_ledger [18421:18431:0219/015138.807738:ERROR:service_manager.cc(210)] Failed to resolve service name: bat_ads

Which account for well over 1k of the console lines.

0reactions

mariosprcommented, Feb 11, 2021

Similar to what I mentioned in detail in https://github.com/brave/brave-browser/issues/8376#issuecomment-774179252 for the case of getting unit_tests building, I’ve started looking into fixing the compilation errors for browser_test as well, which at the moment look very similar to the ones mentioned by @bsclifton in https://github.com/brave/brave-browser/issues/8297#issuecomment-588065370.

And the good news is that I just got them building with a very small adjustment in the source overrides for //c/b/renderer_context_menu/render_view_context_menu.h:

 chromium_src/chrome/browser/renderer_context_menu/render_view_context_menu.cc | 13 +++++++++++++
 chromium_src/chrome/browser/renderer_context_menu/render_view_context_menu.h  |  9 ++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)

And since it’s just such a small change, I’ve repurposed https://github.com/brave/brave-browser/issues/14001 so that it’s not just about fixing the build for unit_tests but also for browser_tests and so we have already a small PR that should fix the build of both binaries, check it out here: https://github.com/brave/brave-core/pull/7899

I’m going to look next into which browser_tests are failing and which ones we could easily skip in a similar fashion to how I did it for unit_tests in https://github.com/brave/brave-core/pull/7901, but for the time being I thought a heads up was in order.

PTAL to https://github.com/brave/brave-core/pull/7899 when you have a moment, thanks!