question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Give users the ability to upload and use their own background images for the new tab page

See original GitHub issue

This is sub task of https://github.com/brave/brave-browser/issues/15252

Overall design is described in https://github.com/brave/brave-browser/issues/15252.

  • Specification
    • Custom image is per-profile configuration
    • Uploaded image is stored only in local device
    • After uploaded, NTP shows uploaded images by default
      • NTP SI will be displayed together if user doesn’t disable it
    • When user choose Brave backgrounds again after uploading custom image, stored image will be deleted

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
btlechowskicommented, Mar 8, 2022

Verification passed on

Brave 1.37.83 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/11622

Default image is brave background

image

Custom image

Verified able to chose custom background

image image

Verified NTP SI was shown image

Verified able to go back to brave background: image

Dark theme

image

Logged: https://github.com/brave/brave-browser/issues/21518

0reactions
stephendonnercommented, Mar 15, 2022

Verified PASSED using

Brave 1.37.65 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 10 Version 21H2 (Build 19044.1566)

Steps:

  1. installed 1.37.65
  2. launched Brave
  3. opened a new-tab page
  4. clicked on Customize on the lower right
  5. chose Upload from device
  6. confirmed the various images
  7. restarted and confirmed they persisted after restart
  8. chose Brave backgrounds
  9. confirmed I could cycle through the various backgrounds
  10. confirmed Sponsored Image ad backgrounds were still in the same position and frequency as before
clock.gif clock.png transparent-fire-gif.gif lexus-is-350.jpg Brave backgrounds (default) Sponsored Image tabs
19640-2 19640-3 19640-4 19640-5 19640-6 19640

Verified PASSED using

Brave 1.37.91 Chromium: 99.0.4844.51 (Official Build) beta (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 12.3 (Build 21E230)

Steps:

  1. installed 1.37.91
  2. launched Brave
  3. opened a new-tab page
  4. clicked on Customize on the lower right
  5. chose Upload from device
  6. confirmed the various images
  7. restarted and confirmed they persisted after restart
  8. chose Brave backgrounds
  9. confirmed I could cycle through the various backgrounds
  10. confirmed Sponsored Image ad backgrounds were still in the same position and frequency as before
cute-transparent-gif-10.gif Blue-Butterfly-PNG-Transparent-Image.png lexus-is-350.jpg Brave backgrounds (default) Sponsored Image tabs
Screen Shot 2022-03-14 at 10 07 55 PM Screen Shot 2022-03-14 at 10 12 53 PM Screen Shot 2022-03-14 at 10 14 49 PM Screen Shot 2022-03-14 at 10 08 15 PM Screen Shot 2022-03-14 at 10 08 32 PM
Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Set a Custom Picture as Chrome New Tab Page ...
Select “Upload an image” from the menu and browse to the location of the image you want to use. Once you choose your...
Read more >
Custom Image Backgrounds For New Tabs - Brave Community
custom background for NTP · Open a new-tab page · Click on Customize on the lower right image · Chose Upload from device....
Read more >
Customize tabs in Chrome browser - Google Support
Add a custom background image to a tab "" · Open Chrome browser. · Click New tab "" . · On the right,...
Read more >
uTab - Google New Tab
Perfect New tab to organize bookmarks with lots of features. ... you need right on the new tab - opportunity to change background...
Read more >
WordPress Background Images: How to Add, Edit ... - Kinsta
On the Maintenance or Coming Soon pages. Overall, if custom background support is enabled in a theme, the user has the ability to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found