question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Handle .onions in all contexts

See original GitHub issue

Description

It seems generally unlikely that anyone entering a .onion address into the address bar means to browse to that site without Tor or to make DNS requests regarding it. When someone does so, we should probably treat it as an oversight. At the very least, we should not tell anyone else about it (no DNS lookups, for instance). But perhaps we should do more and provide a useful notification or even smoothly redirect them to a Private Window with Tor?

Design

Show a “Open in Tor” button in the URL bar when user enters a .onion address or address with .onion available.

image

Dark Theme

Dark theme is supported: image

Assets

Figma: https://www.figma.com/file/5THkuEtO2Ewn9LfqrHZP9a/?node-id=0%3A1

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:15
  • Comments:10 (4 by maintainers)

github_iconTop GitHub Comments

7reactions
tomlowenthalcommented, Dec 11, 2018

I’m embarrassed that I didn’t think of this before. I think it makes sense to treat .onion sites just like any other site if you open it in a non-private window. No need to make a big deal out of it, just quietly use Tor behind the scenes and modify the security indicator to indicate that Brave is relying on the onion protocol rather than HTTPS.

5reactions
librarymdcommented, Dec 11, 2018

Supporting .onion addresses in all contexts would be a game-changer for Brave as a browser. There is no browser doing that yet. To be honest, having a separate private Tor window is too much hassle. There is already TorBrowser as a separate window. Navigating privacy friendly .onion addresses should be as easy as navigating normal web, not harder.

Read more comments on GitHub >

github_iconTop Results From Across the Web

What is this Broswer for - Mobile Support - Brave Community
I'm trying to visit .onion addresses and they don't seem to be ... I've tried several different s… ... Handle .onions in all...
Read more >
1382359 - Treat .onion as a secure context - Bugzilla@Mozilla
I was thinking about amending the URL list in the first add_task() with a ["http://123456789abcdef.onion", false] pair making sure the whitelist pref is...
Read more >
Onion Production Guide | UGA Cooperative Extension
This publication represents the latest information available on the commercial production of short-day onions in south Georgia.
Read more >
Mistakes Everyone Makes When Cooking Onions - Mashed
According to Bon Appétit, yellow onions are a great all-purpose option: They ... and they're probably going to taste good in most contexts....
Read more >
How to cook onions: Why recipe writers lie and lie about how ...
How long does it really take to caramelize onions? AdeFinlay/iStock ... Could onions be browned, at all, in 10 minutes?
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found