Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Have a "hold to actually close" keyboard shortcut for pinned tabs

See original GitHub issue

Description

Currently, pinned tabs can be closed with Ctrl+W / Cmd+W, and we’ve clarified this is the intended behavior.

A Chrome user recently suggested that we could have a “Hold X to close”, similar to the Chrome/Chromium default behavior for Ctrl+Q/Cmd+Q for quit. It would look something like this:

Steps to Reproduce

Fresh profile
Visit a site
Right click tab, pick Pin Tab
Go into pinned tab
Hit Ctrl+W or Cmd+W

Actual result:

Pinned tab closes ☹️

Expected result:

User should have to hold shortcut to close

Reproduces how often:

100%

Brave version (brave://version info)

Brave	0.68.56 Chromium: 75.0.3770.90 (Official Build) nightly(64-bit)
Revision	a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS	Mac OS X

Issue Analytics

State:
Created 4 years ago
Reactions:14
Comments:10

Top GitHub Comments

3reactions

rebroncommented, Jul 5, 2019

https://github.com/brave/brave-browser/issues/4988#issue-458162978 Approach to solve inadvertently closing pinned tabs via ignoring CMD + W pref, might be a good way to go to instead of a warning.

1reaction

dvcrncommented, Jan 27, 2021

I like the idea of having a setting to disable ever closing pinned tabs, similar to how safari is doing it. You can still right-click and then hit “close”, but pinned tabs should be pinned until they are explicitly unpinned.

Hitting CMD-W on a pinned tab, if that tab is the last tab, should just close the browser window and leave the tab as is.