question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

https://www.hyatt.com and other websites fail to load when `brave://flags#brave-block-screen-fingerprinting` is enabled

See original GitHub issue

Description

Looks like we have a webcompat bug where certain websites fail to load when brave://flags#brave-block-screen-fingerprinting is enabled. Originally reported by @ryanbr and confirmed by @pes10k & @arthuredelstein. It was decided to rollback the BraveBlockScreenFingerprinting study on all the channels as per https://github.com/brave/brave-variations/pull/473 until we know what’s causing the issue.

The strange part that we need to figure out is why the issue occurs even when disabling Brave Shields or disabling FP.

Steps to Reproduce

  1. launch brave (used 1.48.10 Chromium: 108.0.5359.48 in this case)
  2. enable brave://flags#brave-block-screen-fingerprinting (need to use brave://flags as we rolled back the changes via Griffin)
  3. restart the browser once brave://flags#brave-block-screen-fingerprinting has been enabled
  4. attempt to load https://www.hyatt.com and you’ll notice that the page is completely blank

There’s also more QA verification notes via https://github.com/brave/brave-variations/pull/472#issuecomment-1329710539.

Actual result:

204371870-207514d7-5717-4e2e-bb3e-dd573da77d47

Expected result:

204372086-706cb1ac-4b50-44ec-b03e-256cf2376d38

Reproduces how often:

100% reproducible when using the STR/Cases outlined above

Brave version (brave://version info)

Brave | 1.48.10 Chromium: 108.0.5359.48 (Official Build) nightly (64-bit)
-- | --
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS | Windows 11 Version 22H2 (Build 22621.819)
Brave | 1.47.104 Chromium: 108.0.5359.48 (Official Build) beta (64-bit)
-- | --
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS | Windows 11 Version 22H2 (Build 22621.819)
Brave | 1.45.133 Chromium: 107.0.5304.141 (Official Build) (64-bit)
-- | --
Revision | cddb1ab381a982f400a57e15e14080e1aaaca4b8-refs/branch-heads/5304_105@{#3}
OS | Windows 11 Version 22H2 (Build 22621.819)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Issue Analytics

  • State:closed
  • Created 10 months ago
  • Comments:6 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
arthuredelsteincommented, Nov 29, 2022

I have tracked down the problem to the value of outer[Width|Height in iframes. In the farbling screen protection, we spoof outer[Width|Height] to inner[Width|Height] for iframes. For example, in a document with innerWidth = 100 containing an iframe with innerWidth = 20, we return an outerWidth value for the document near 100 and an outerWidth value for the iframe near 20. It appears that a bot-detection script on these websites notices that outer[Width|Height] for the iframe does not match outer[Width|Height] for the top-level document and therefore decides to reject the visitor.

I found I can fix this problem on both websites (hyatt.com and realestate.com.au) by changing the farbling code to return a value for outer[Width|Height] in the iframe that matches inner[Width|Height] of the top-level document rather than the iframe. So, in our example, in a document with innerWidth = 100 containing an iframe with innerWidth = 20, we will return an outerWidth for both the top-level document and iframe near 100.

(I’m working on a PR that incorporates this fix.)

0reactions
GeetaSarvadnyacommented, Dec 9, 2022

Verification PASSED on

Brave | 1.46.141 Chromium: 108.0.5359.99 (Official Build) (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 10 Version 21H2 (Build 19044.2251)

  • ensured that https://www.hyatt.com loads without issues when brave://flags#brave-block-screen-fingerprinting enabled
  • ensured that https://www.realestate.com.au/buy/in-melbourne,+vic+3000/list-1 loads without issues when brave://flags#brave-block-screen-fingerprinting enabled
Example Example
image image
Example Example
image image
Read more comments on GitHub >

github_iconTop Results From Across the Web

Website not loading - browser - Brave Community
https://www.hyatt.com and other websites fail to load when `brave://flags#brave-block-screen-fingerprinting` is enabled.
Read more >
Hotel Reservations | Book Hotel Rooms Online - Hyatt Hotels ...
Save up to 15% only on Hyatt.com. Book now at any of our 1200+ Hyatt hotels and resorts worldwide and get the best...
Read more >
Sign In - Hyatt
Join World of Hyatt. Accessing Your Account Information. If you can't remember your World of Hyatt membership number, username or password, please contact ......
Read more >
Customer Service - Hyatt
Customer Service ; Retrieve Hotel Bill · Credit Card Authorization Form ; Reservations · World of Hyatt FAQs ; Share Feedback on a...
Read more >
Accessing Your Account - Customer Service - Hyatt
All browsers must be Java Script enabled to view the site. I keep getting an error saying that my account number is invalid....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found