Implement cosmetic blocking [tracking]
See original GitHub issueNotes for QA (edit by @bsclifton)
- In 1.5, Cosmetic filtering needs to be enabled via brave://flags/#brave-adblock-cosmetic-filtering
- It wasn’t until 1.6 that this setting’s default value was changed from
false
totrue
(see this PR for more info) - https://github.com/brave/brave-core/pull/3303 (original implementation) only mentions automated tests, does not feature a test plan
Test Plan
In 1.5: First, enable cosmetic filtering via brave://flags/#brave-adblock-cosmetic-filtering
Then, in both 1.5 and 1.6: Navigate to https://enpt.dict.cc in a new tab Ensure there is no large square whitespace under the word “Advertisement” in the center of the page (by the “dict.cc Dicionário Inglês-Português: Portuguese-English and Multilingual Dictionary” header)
Description
Would be great to support EasyList and similar cosmetic filter rules. Much of this work has already been done in https://github.com/brave/adblock-rust. This issue is a tracking issue to keep track of all the branches and changes needed across multiple projects to land this in brave-browser.
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (3 by maintainers)
Top Results From Across the Web
How ad blocking works - AdGuard Knowledgebase
In most cases, it's enough to use the above-mentioned basic and cosmetic rules to filter ads. But when it is necessary to change...
Read more >Third-party cosmetic filtering - Brave Browser
While Brave uses many of the same filter lists that other tracking and ad blocking tools use, Brave's mission differs from existing filter ......
Read more >Not all adblockers are born equal - Tech @ Cliqz
Cosmetics (or element hiding) allow to hide or defuse ads which were ... Adblockers use such capabilities whenever blocking requests is not ...
Read more >Ad-blocking companies block 'unblockable' tracker
These requests go to ad companies that use various techniques to identify your browser and track it across multiple sites. Ad-blocking companies ...
Read more >What Is The Best AD Blocker - Ghostery
Find out how Ghostery's ad and tracker blocker extension can enhance your ... Ad blockers use community lists or 'blocklists' to filter web...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@szaimen crashes on Windows should be fixed as of https://github.com/brave/brave-core/pull/4540.
Currently there are no additional settings regarding cosmetic filtering; this work supports the cosmetic filters that will soon be shipped from our filter lists.
The feature flag will be on by default with https://github.com/brave/brave-core/pull/4511.
When another fix is attempted, we’ll want to link to test plan if manual QA is required. If not and everything is covered by automation, we can change label to
QA/No