"Include in Auto-Contribute" pref not working for Greaselion-enabled publishers
See original GitHub issueDescription
“Include in Auto-Contribute” pref auto-toggles to OFF after first flipping OFF to ON, then dismissing panel.
Steps to Reproduce
- new profile, launch Brave with
--args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5
- click “Skip welcome tour”
- click “Start using Rewards”
- click “Claim my Rewards”
- pass the reCaptcha challenge
- load
https://twitter.com/bravelaurenwags
- click on the BAT icon in the URL bar
- notice that “Include in Auto-Contribute” is toggled ON
- toggle it from ON to OFF
- dismiss the Rewards panel
- click on the BAT icon in the URL bar again
- now click to toggle from OFF to ON, dismiss the panel
- reopen the panel now, and notice that “Include in Auto-Contribute” self-toggles to OFF
Actual result:
“Include in Auto-Contribute” auto-toggles back to OFF, and the following exception is dumped in the console:
[19807:775:0301/110936.784322:WARNING:CONSOLE(1)] "Received external message from a sender who is not allowed to send messages to this background. Origin: chrome-extension://jidkidbbcafjabdphckchenhfomhnfma, URL: chrome-extension://jidkidbbcafjabdphckchenhfomhnfma/brave_rewards_panel.html", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
Expected result:
“Include in Auto-Contribute” should be ON, as the ON/OFF preference for “Include in Auto-Contribute” should persist between panel openings/closings.
Reproduces how often:
100%
Brave version (brave://version info)
Brave | 1.21.70 Chromium: 89.0.4389.69 (Official Build) (x86_64) |
---|---|
Revision | 6df9174a477a0bea2118cb4669954d517be16104-refs/branch-heads/4389@{#1332} |
OS | macOS Version 11.2.2 (Build 20D80) |
Version/Channel Information:
- Can you reproduce this issue with the current release? Yes (
1.20.110
) - Can you reproduce this issue with the beta channel? Yes
- Can you reproduce this issue with the nightly channel? Yes
cc: @emerick @LaurenWags
Issue Analytics
- State:
- Created 3 years ago
- Comments:7 (4 by maintainers)
@stephendonner Nice, I can repro following what you did in that GIF. Will investigate, thanks.
Thanks @stephendonner for the very detailed description - will look into it!