question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incorrect error dialog used when credentials fail

See original GitHub issue

Description

Incorrect error dialog used when credentials fail

Steps to Reproduce

  1. Complete the steps under Brave Premium login > Purchasing VPN with a new account from https://github.com/brave/brave-browser/issues/15804, making sure to specify the current month and year for the credit card’s expiration date
  2. confirm you can connect to your new Brave VPN account
  3. shut down Brave
  4. open Date & Time in System Preferences and advance the OS date to the 1st of next month
  5. relaunch Brave
  6. connect to Brave VPN

Actual result:

Screen Shot 2022-06-01 at 11 32 02 AM

Expected result:

From Figma:

Screen Shot 2022-05-20 at 11 05 52 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.41.5 Chromium: 102.0.5005.50 (Official Build) nightly (x86_64)
Revision f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS macOS Version 11.6.6 (Build 20G624)

@aguscruiz @bsclifton @simonhong @brave/qa-team

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:6

github_iconTop GitHub Comments

1reaction
GeetaSarvadnyacommented, Dec 1, 2022

Verification PASSED on

Brave | 1.46.131 Chromium: 108.0.5359.71 (Official Build) (64-bit)
-- | --
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS | Windows 10 Version 21H2 (Build 19044.2251)

  • Verified the STR from the description, On 1st of Dec we are getting “Connected” state which is correct as the subscription is purchased on Nov 30th and subcription is valid till 32 days.

  • Encountered and logged https://github.com/brave/brave-browser/issues/26982

Thread for the tokens expiry discussion https://bravesoftware.slack.com/archives/C021S0FN3V1/p1669314173558939?thread_ts=1669225513.288039&cid=C021S0FN3V1

Nov 30th

Example Example
image image

Dec 1st

Example Example
image image
0reactions
stephendonnercommented, Nov 23, 2022

@stephendonner @MadhaviSeelam I have followed the STR from the description. When I advance the system date to 1st of next month (1st Dec 2022) I am not getting Edit payment menthod popup when I tap on the VPN icon in the URL bar. VPN is still in the connected state.

<snip>

Same. Using

Brave 1.46.126 Chromium: 108.0.5359.48 (Official Build) beta (64-bit)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS Windows 10 Version 22H2 (Build 19045.2311)

I follow the same steps, and after advancing to the 1st of next month (from today’s correct issue date of 11-23-2022), and relaunching Brave, BraveVPN is still able to connect without throwing up the Edit your payment dialog we see on macOS.

image

Read more comments on GitHub >

github_iconTop Results From Across the Web

The browser based authentication dialog failed to complete ...
It seems to me that the WindowsFormsWebAuthenticationDialog.ShowBrowser() is causing the problem, not my credentials or account, but what could be the root ...
Read more >
Which error message is better when users entered a wrong ...
The easiest and most common phrase to use is: "You have entered an invalid username or password".
Read more >
Fail to paste password into credential dialog box - Windows ...
In this article. This article provides help to fix a File system error that occurs when you paste password into a credential dialog...
Read more >
[Windows] No "username or password is incorrect" or "account ...
Click on the "Show Password" button. Enter an invalid password in "Windows Security" dialog. [Expected result]:. The "username or password is incorrect" message...
Read more >
Windows login fails when correct credentials are entered after ...
Information · The user attempts to sign-in and enters a bad set of credentials at the Windows GINA dialog. · The Odyssey Access...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found