Incorrect error dialog used when credentials fail
See original GitHub issueDescription
Incorrect error dialog used when credentials fail
Steps to Reproduce
- Complete the steps under
Brave Premium login
>Purchasing VPN with a new account
from https://github.com/brave/brave-browser/issues/15804, making sure to specify the current month and year for the credit card’s expiration date - confirm you can connect to your new
Brave VPN
account - shut down Brave
- open
Date & Time
inSystem Preferences
and advance the OS date to the1st of next month
- relaunch Brave
- connect to
Brave VPN
Actual result:
Expected result:
From Figma:
Reproduces how often:
100%
Brave version (brave://version info)
Brave | 1.41.5 Chromium: 102.0.5005.50 (Official Build) nightly (x86_64) |
---|---|
Revision | f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648} |
OS | macOS Version 11.6.6 (Build 20G624) |
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:6
Top Results From Across the Web
The browser based authentication dialog failed to complete ...
It seems to me that the WindowsFormsWebAuthenticationDialog.ShowBrowser() is causing the problem, not my credentials or account, but what could be the root ...
Read more >Which error message is better when users entered a wrong ...
The easiest and most common phrase to use is: "You have entered an invalid username or password".
Read more >Fail to paste password into credential dialog box - Windows ...
In this article. This article provides help to fix a File system error that occurs when you paste password into a credential dialog...
Read more >[Windows] No "username or password is incorrect" or "account ...
Click on the "Show Password" button. Enter an invalid password in "Windows Security" dialog. [Expected result]:. The "username or password is incorrect" message...
Read more >Windows login fails when correct credentials are entered after ...
Information · The user attempts to sign-in and enters a bad set of credentials at the Windows GINA dialog. · The Odyssey Access...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Verification PASSED on
Verified the STR from the description, On 1st of Dec we are getting “Connected” state which is correct as the subscription is purchased on Nov 30th and subcription is valid till 32 days.
Encountered and logged https://github.com/brave/brave-browser/issues/26982
Thread for the tokens expiry discussion https://bravesoftware.slack.com/archives/C021S0FN3V1/p1669314173558939?thread_ts=1669225513.288039&cid=C021S0FN3V1
Nov 30th
Dec 1st
Same. Using
I follow the same steps, and after advancing to the 1st of next month (from today’s correct issue date of 11-23-2022), and relaunching Brave,
BraveVPN
is still able to connect without throwing up theEdit your payment
dialog we see on macOS.