question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Little indication of IPFS tab selected in settings

See original GitHub issue

Description

All settings tabs have icons which change when the tab is selected, except for IPFS which stays grey regardless of selection status.

Steps to Reproduce

  1. Open settings
  2. Select any tab other than IPFS
  3. Notice that the icon turns orange
  4. Select IPFS tab
  5. Notice that the icon does not turn orange

Actual result:

IPFS icon shows no indication of selected tab

Expected result:

IPFS icon changes colour to indicate selected tab

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.25.68 Chromium: 91.0.4472.77 (Official Build) (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? YES
  • Can you reproduce this issue with the beta channel? UNTESTED
  • Can you reproduce this issue with the nightly channel? UNTESTED

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? UNTESTED
  • Does the issue resolve itself when disabling Brave Rewards? UNTESTED
  • Is the issue reproducible on the latest version of Chrome? UNTESTED

Screenshots:

Wallet Extension Getting started IPFS
image image image image

On a somewhat-related note, I believe the hightlighted Wallet tab icon could be improved - it’s much less highlighted than the others which makes it stick out IMO.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
karenkliucommented, Jul 6, 2021

@stephendonner Dark theme hover seems to be using the incorrect color, and therefore not passing accessibility standards. It should be this: Screen Shot 2021-07-06 at 4 35 47 PM 737ADE

Also, looks like the icon in the sidebar is missing the selected and hover color, as well as the selected accent line: Screen Shot 2021-07-06 at 4 39 07 PM

0reactions
stephendonnercommented, Jul 6, 2021

Verified PASSED using

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)
selected selected hover hover
Screen Shot 2021-07-06 at 3 51 55 PM Screen Shot 2021-07-06 at 3 54 36 PM Screen Shot 2021-07-06 at 3 52 52 PM Screen Shot 2021-07-06 at 3 53 04 PM
Read more comments on GitHub >

github_iconTop Results From Across the Web

How to run IPFS with Embark framework demo program
Solved it. Using ipfs config --json API.HTTPHeaders.Access-Control-Allow-Credentials '["true"]' ipfs config --json API.HTTPHeaders.
Read more >
How to integrate IPFS with Ethereum explained - QuickNode
1. It can be costly to store massive files on a blockchain mainnet, and this is where decentralized file... 2. The web that...
Read more >
Build a simple Ethereum + InterPlanetary File System (IPFS)+ ...
Click the “Compile” tab, then click the grey “Details” button. This will bring up the Details window. Copy the “ABI,” it is a...
Read more >
Learn How to Easily Create Your Own Dedicated IPFS Gateway
Learn how to spin up a Dedicated IPFS Gateway that is fast and branded for you with custom domains. Share your IPFS content...
Read more >
Infura IPFS API | Scalable and distributed IPFS storage ...
Infura's IPFS API connects applications of all sizes to distributed secure storage. No complex setups. ... Store as much, or as little, data...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found