{macOS} Crash on launch

Description

Sometimes when Brave is launched by another app with a URL to open, it crashes.

Steps to Reproduce

Intermittent, but in general this is what happens:

1. I’m in Vienna - an RSS application - and click on a link to open in the browser.
2. Brave is my default browser and it starts up and crashes immediately (before showing any windows)
3. When I launch Brave again, a dialog shows up and goes away (can’t read it - not sure what it says), then Brave is in a state where it must be force-quit
4. When I launch Brave again, all my previous tabs are closed.

It’s happened enough now that I’m actually reporting it even though there isn’t a lot of info to go on 😃

Reproduces how often:

Intermittent issue.

Brave version (brave://version info)

Brave	0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS	Mac OS X
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.131 Safari/537.36

Version/Channel Information:

• Can you reproduce this issue with the current release?

As mentioned - it is an intermittent issue. It’s been there for at least a few releases now.

• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Have not tried other channels since it’s not reproducible.

Other Additional Information:

Edit: I just realized crash is in a worker thread, so the trace I had here is useless.

Process:               Brave Browser [98648]
Path:                  /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
Identifier:            com.brave.Browser
Version:               74.0.63.55 (63.55)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Brave Browser [98648]
User ID:               501

Date/Time:             2019-05-10 12:17:48.775 -0400
OS Version:            Mac OS X 10.12.6 (16G1918)
Report Version:        12
Anonymous UUID:        BAFB1198-E108-24F5-0223-0CA33EBD8ED4


Time Awake Since Boot: 560000 seconds

System Integrity Protection: enabled

Crashed Thread:        14  TaskSchedulerForegroundWorker

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000008

VM Regions Near 0x8:
--> 
    __TEXT                 000000010f50d000-000000010f537000 [  168K] r-x/rwx SM=COW  /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

• Does the issue resolve itself when disabling Brave Shields?

Unfortunately it’s an intermittent problem.

• Does the issue resolve itself when disabling Brave Rewards?

Rewards is off.

• Is the issue reproducible on the latest version of Chrome?

I’d never had this issue with Chrome - haven’t got it installed since I switched to Brave a few months ago.

[kjozwiak]

@asmaloney mind adding the above into https://github.com/brave/brave-browser/issues/3839? We closed this is a duplicate of https://github.com/brave/brave-browser/issues/3839.

[asmaloney]

This is still an issue and it’s getting really frustrating.

Version 0.65.121 Chromium: 75.0.3770.100 (Official Build) (64-bit)

This time it died when installing the latest update.

If it didn’t kill all my tabs it would be… less frustrating.