question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Missing focus states/events for radio buttons in VPN-support dialog

See original GitHub issue

Description

Missing focus states/events for radio buttons in VPN-support dialog

Steps to Reproduce

  1. install 1.39.86
  2. launch Brave
  3. set up VPN on development env for the SKUs SDK (lots of separate steps)
  4. click on the VPN icon
  5. click on the location
  6. press tab / shift+tab (reverse) to try to cycle through the radio buttons of the elements

Actual result:

Radio button controls are not in the tabindex and are skipped

no-tabindex-radio-buttons

Expected result:

Each element and their radio-button control should be tab-focusable/have a focus ring

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.86 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

@bsclifton @aguscruiz @nullhook

Issue Analytics

  • State:open
  • Created a year ago
  • Reactions:1
  • Comments:6

github_iconTop GitHub Comments

1reaction
stephendonnercommented, Jun 21, 2022

Looks like the issue is fixed and working fine on Windows 10 x64 - Brave version 1.41.74. I have tried both the Tab and shift+tab to cycle through the radio buttons, and I could see the focus ring around the selected radio button.

VPN radio button focus ring VPN radio button focus ring

Thanks for taking a look @GeetaSarvadnya. Even in this video, we can see that the radio buttons themselves are only selectable/tab-able via the mouse. Keyboard operations work but only the country labels get a focus ring.

IMHO (back me up @aguscruiz!) there should be a focus ring on the radio buttons, same as there currently is for the country labels’ controls.

0reactions
stephendonnercommented, Jun 21, 2022

(The radio buttons clearly have a selected state, but not the focused one I’d expect from tabing.)

Read more comments on GitHub >

github_iconTop Results From Across the Web

Dialog focus is not on checked RadioButton,but on the first ...
After run ③、the focus is on first RadioButton(CButton A) in the dialog(A), and Button C is checked on . Refer to below info,it...
Read more >
Block element via CSS doesn't capture the correct element #904
Missing focus states/events for radio buttons in VPN-support dialog #22631 ... Clicking on VPN-location radio buttons doesn't work #22632.
Read more >
javascript - making focus invisible for radio buttons on click but ...
How do I make focus invisible for radio buttons only on click (focus should be visible through keyboard navigation).
Read more >
Diff - platform/frameworks/base - Google Git
+ * Gets the codec selection priority. * The codec selection priority is relative to other codecs: larger value * means higher priority....
Read more >
Tabbing through form never gives focus to radio buttons or c
Hello, I'm having an issue where when I have either radio buttons or checkboxes on a form in Angular they never gain focus...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found