question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

No conversion due to lack of Slash at the end of urlPattern

See original GitHub issue

Found while testing https://github.com/brave/brave-browser/issues/8362

Steps to Reproduce

  1. In the catalog set urlPattern to https://travala.com
  2. In the catalog set targetUrl to https://travala.com
  3. trigger the ad
  4. click on the ad to open the targetUrl

Note: if you add / at the end the conversion is successful

Actual result:

No conversion due to lack of slash at the end of urlPattern.

Expected result:

TBD

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @tmancey @jsecretan @rebron

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
bscliftoncommented, Jun 3, 2020

@tmancey is this issue closed? (asking as I see it’s in Done column)

0reactions
btlechowskicommented, Jun 5, 2020

Logged the issue in the repo that was suggested by @jsecretan : https://github.com/brave/ads-serve/issues/990

Read more comments on GitHub >

github_iconTop Results From Across the Web

page not found without forward slash in a url django
Page not found (404) Request Method: GET Request URL: http://localhost:8000/product/list Using the URLconf defined in urlconf, Django tried ...
Read more >
Troubleshooting Invalid URL Patterns Involving Trailing '/' and '/*'
The reason could be too unnoticeable sometimes, such as the existence of a slash (/) at the end of the URL - a.k.a....
Read more >
Should You Have a Trailing Slash at the End of URLs? - Ahrefs
A trailing slash is a forward slash (“/”) placed at the end of a URL such as domain.com/ or domain.com/page/. But should you...
Read more >
Trailing slash at end of URLs? | SEO Forum - Moz
Hi, I'm just about to put up a new site and I need to decide between having no trailing slash at the end...
Read more >
Difference between url ending with forward slash and without ...
12 votes, 23 comments. Example: urlpatterns = [ path('new/', views.new_list, name='new_list'), path(' /', views.view_list…
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found