Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PDF.js should NOT be shown in brave://extensions when launched with --show-component-extension-options

See original GitHub issue

Description

PDF.js should NOT be shown in brave://extensions when launched with --show-component-extension-options

(Sorry!) I missed this, apparently, when verifying https://github.com/brave/brave-browser/issues/14338 (with the testcase in https://github.com/brave/brave-core/pull/8061)

Steps to Reproduce

Go to https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm
Verify that you can install PDF.js
Verify that PDF.js puts a browser action button in the extension area
Verify that PDF.js shows in brave://extensions
Open a PDF document and verify PDF.js is used
Launch Brave from the command line with --show-component-extension-options
Load brave://extensions
Look for the PDF Viewer / PDF.js extension (shouldn’t be there)

Actual result:

Expected result:

There should be no PDF.js / PDF Viewer extensions visible in brave://extensions, when launched with --show-component-extension-options

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.25.2 Chromium: 90.0.4430.51 (Official Build) nightly (x86_64)
Revision	32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS	macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

Can you reproduce this issue with the current release? yes
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

/cc @kjozwiak @mariospr @GeetaSarvadnya

Issue Analytics

State:
Created 2 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

2reactions

kjozwiakcommented, Apr 8, 2021

@stephendonner if you were using test plan from https://github.com/brave/brave-core/pull/2342 you’ll want to ignore anything mentioning PDF.js as we removed that from packaging. It’s treated the same as any regular extension now

That’s where the confusion occurred. I was running through Linux and noticed that I can still see the PDF Viewer we installed via brave://extensions while running Brave with --show-component-extension-options. The test case basically mentioned that we shouldn’t be visible which was strange but figured it was an issue. @stephendonner confirmed he was seeing the same thing.

Thanks for clearing it up @simonhong & @bsclifton 👍

1reaction

bscliftoncommented, Apr 8, 2021

@GeetaSarvadnya the test plan shown was from a PR 3 years ago; maybe the right thing to do would have been to copy the test plan and edit instead of linking to the old test plan in https://github.com/brave/brave-core/pull/8061