"Private Window with Tor" and Snowflake's `Volunteer to help other connect...` Settings options should be disabled when Tor is admin-disabled

Description

“Private Window with Tor” and Snowflake’s Volunteer to help other connect... Settings options should be disabled when Tor is admin-disabled

Found while testing https://github.com/brave/brave-browser/issues/17530.

Steps to Reproduce

1. write defaults write com.brave.Browser TorDisabled -integer 1 into a Terminal.app window and press enter
2. new profile
3. launch Brave
4. click on the “hamburger” menu and notice there’s no New Private Window with Tor option
5. load brave://policy and confirm TorDisabled is set to true
6. open brave://settings/extensions and look at the Private Window with Tor option

Actual result:

Private Window with Tor is still toggle-able to on and off, and works.

example	example

Expected result:

Private Window with Tor should be disabled, like Windows and Linux.

Windows	Linux

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.30.38 Chromium: 93.0.4577.51 (Official Build) nightly (x86_64)
Revision	762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS	macOS Version 11.5.2 (Build 20G95)

[MrAshRhodes]

@simonhong This actually worked for me.

Setting the following com.brave.Browser.plist file in /Library/Managed Preferences/$username

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
 <dict>
  <key>TorDisabled</key>
  <true/>
 </dict>
</plist>

It only applies to the current user rather than the machine

Moving from the $username for to /Library/Managed Preferences/

Made it mandatory for the whole machine.

The file that contains policies that are Recommended is

~/Library/Preferences/com.brave.Browser.plist

Hope this helps anyone.

[MadhaviSeelam]

Tested in Win 11 x64. Following have been found when TorDisabled is true:

1. Install 1.47.121
2. launch Brave
3. opened brave://settings/privacy in a new-tab
4. enabled Volunteer to help others connect to the Tor network toggle
5. clicked on Extensions puzzle>>Snowflake
6. opened brave://extensions in a new-tab
7. Snowflake extension is shown
8. close the browser
9. opened Registry Editor
10. created BraveSoftware/Brave key under HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Policies\
11. create DWORD (32-bit) value named TorDisabled with value 1
12. launch Brave
13. open brave://policy
14. confirmed TorDisabled is true
15. open brave://settings/privacy
16. click Extension puzzle>>Snowflake extension

• Volunteer to help other connect... was toggled Off and greyed out
• However Snowflake extension was NOT disabled
• Private Window with Tor toggle is Off and Private Window with Tor option in the hamburger menu is not available

ex1	ex2	ex3