question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Question-mark icon in connect-permissions dialog goes to top-level Brave Support website, instead of a specific article

See original GitHub issue

Description

Question-mark icon in connect-permissions dialog goes to top-level Brave Support website, instead of a specific article

Steps to Reproduce

  1. load https://permission.site/
  2. click on HID or USB
  3. in the resulting dialog, click on the (?) icon, bottom left

Actual result:

Goes to https://support.brave.com/hc/en-us

Screen Shot 2021-04-19 at 4 32 13 PM Screen Shot 2021-04-19 at 4 32 15 PM

Expected result:

Not sure; should this go to https://github.com/brave/brave-browser/wiki/Web-API-Permissions which is the placeholder in the Learn more text for the dialog from https://github.com/brave/brave-browser/issues/14126 and https://github.com/brave/brave-browser/issues/14127? Or somewhere else, within the Brave Support site?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (x86_64)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

/cc @karenkliu for suggestions/directions, and @goodov @pes10k for same/visibility

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:18 (3 by maintainers)

github_iconTop GitHub Comments

3reactions
goodovcommented, May 3, 2021

@Ayushsunny hey! Try to find it yourself, it might be tricky, but it’s a good skill to exercise. You need to find where in the code the browser creates this dialog, so you can search for files/classes that contain words like permission, dialog, view, ui. The other option is try to find the current URL the browser opens when you click the question-mark icon and reverse search places in code where it’s used.

1reaction
nilanshu96commented, Jun 11, 2021

Thank You @stephendonner. Brave is an amazing browser and I’d be happy to contribute more in the future.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How do I change site permissions? - Brave Help Center
Change settings for all sites. On your computer, open Brave. At the top right, click Menu icon_MM.png → Settings .
Read more >
Add support for time limits for Web API permissions in brave ...
Question-mark icon in connect-permissions dialog goes to top-level Brave Support website, instead of a specific article #15376.
Read more >
Administration Guide - HARMONY ENDPOINT - Check Point
Guard & Anti-Ransomware Settings" on page 125. 22 November. 2022. Added the Harmony Endpoint Security Client versions and policy mode supported ...
Read more >
BBO Helper browser extension - La Jolla Bridge
BBO Helper is a browser extension for Firefox, Google Chrome, Microsoft Edge, and Brave written by Matthew Kidd that enhances the functionality of...
Read more >
Custom Templates Guide For Google Tag Manager
A comprehensive guide to building custom templates (both tag templates and variable templates) in Google Tag Manager.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found