question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Regional adblock filters are not pre-selected based on locale

See original GitHub issue

Follow up to https://github.com/brave/brave-browser/issues/1931

Steps to Reproduce

1, Start with a clean profile 2. Set locale to “fr” in chrome://settings/languages 3. Restart Brave 4. Visit brave://adblock 5. Verify that French regional list is selected

Actual result:

FRA: EasyList Liste FR is not pre-selected

image

Expected result:

FRA: EasyList Liste FR is pre-selected image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Reproduced on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Not reproducible on

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

image

So this is a regression.

Note: also reproduced with Polish language. I also changed system locale, but it didn’t fix the issue

cc @brave/legacy_qa @emerick

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:9 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
antonok-edmcommented, Feb 2, 2022

@btlechowski the fix I mentioned above is just for the Japanese and Indian lists, but that’s already available everywhere (shipped as a component update).

If there are still other locales that should be pre-selecting lists and aren’t, let me know and I can push out a similar update for those as well.

0reactions
btlechowskicommented, Feb 15, 2022

Still reproducible

Brave 1.37.46 Chromium: 98.0.4758.87 (Official Build) nightly (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Windows 7 Service Pack 1 (Build 7601.24544)

After changing language to CZE, Easylist-Cookie List - Filter Obtrusive Cookie Notices was added to the list I would expect CZE, SVK: EasyList Czech and Slovak to be add. This could be related to https://github.com/brave/brave-browser/issues/20825

image

Read more comments on GitHub >

github_iconTop Results From Across the Web

Introduction to Filter Lists - AdBlock
These rules are also known as filters, and they are provided in collections called filter lists. The filter lists are maintained by volunteers ......
Read more >
How ad blocking is done: a look inside filter developing and ...
We explain what filter lists are, what they do, how they are maintained and why upcoming Google Chrome changes threaten all of it....
Read more >
Default set of filters - Adblock Plus
A very minimal set of general filters can filter 40 - 70 % of ads in most of pages (even not English webpages),...
Read more >
Ultimate Guide to Ad-Blocking Filter Lists - Comparitech
For an ad-blocker to work effectively, it needs a way to filter out these ... according to your browser's language settings, so you...
Read more >
Block ALL ads with this…(and speed up your internet)
You can't block this AD!! (It's time to get your A+ and CCNA with ITProTV): https://ntck.co/itprotv (30% off FOREVER) *affiliate linkBlock ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found