Remove `deep-freeze-node` dependency: the project is no longer installable on mac arm

I can’t install the project. Steps to reproduce the issue:

git clone [e-mail]:brave/brave-browser.git
cd brave-browser
npm install
cd src
rm -rf brave # otherwise error "directory already exists", BTW that should be mentioned in the doc
cd ..
npm run init

And I get:

    fatal: repository 'undefined' does not exist

It seems the function getNPMConfig relies on env vars that are obviously not present on my system. But there is no mention about it in the Brave installation procedure.

What’s wrong here?

Just in case, I mention that I’m on macOS 10.14.6 (Mojave).

[Aragar199]

I also encountered the same issue. Problem is that the path to the repository url is broken.

There is a string replacement that is making - into _ at https://github.com/brave/brave-browser/blob/master/lib/util.js#L5

So when brave-browser goes looking for brave-core in package.json, it can never find it because the key is changed to brave_core and it ends up undefined

You can change it to brave_core in https://github.com/brave/brave-browser/blob/master/package.json#L38

That fixes it there, but then it breaks in brave-core which has its own getNPMConfig that does not do the same string replacement to change -. So it scans for brave-core but never finds it because it is brave_core now.

You can then change at https://github.com/brave/brave-core/blob/master/build/commands/lib/config.js#L77 brave-core to brave_core so when it scans for the repo url it can find it because it is now brave_core in brave-browser/package.json.

Then change the repo url and branch name to point to the brave-core version that has this change:

I was able to install using these steps, but it’s a patch job and should probably have a real fix instead.

[bridiver]

I agree that all the setup instructions should be together so we’ll reorganize things a little bit

On Feb 22, 2021, at 12:14 AM, Brian Clifton [e-mail] wrote:

@Kwadz there’s only a different procedure if you make edits to the code. Everyone has read access to the repo, but creating branches on the remote and pushing to the remote is limited to employees

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.