Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove deprecated timers from Brave Ads

See original GitHub issue

Description

Remove deprecated timers (SetTimer, OnTimer and KillTimer) from bat-native-ads and bat-native-confirmations

Test plan

See https://github.com/brave/brave-core/pull/5229

Issue Analytics

State:
Created 3 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

tmanceycommented, May 11, 2020

@LaurenWags The Brave Ads onboarding notification is removed after 1 week. You can also reduce this time to 5 minutes with the --brave-ads-debug command-line arg

0reactions

LaurenWagscommented, May 12, 2020

Verified passed with

Brave	1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from https://github.com/brave/brave-core/pull/5229
Confirmed that if I install 1.8.x on a non-Ads region (ex. Aruba), and upgrade to 1.9.x, I get the Brave Ads have arrived notification on BAT logo as expected.
- Confirmed that if I use the --brave-ads-debug flag as noted in https://github.com/brave/brave-browser/issues/9153#issuecomment-626567087, the notification goes away after 5 minutes as noted
- Confirmed that if I do not use the --brave-ads-debug flag, the notification does not go away after 5 minutes, but does go away after 1 week (+ some time for jitter).

Verification passed on

Brave | 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from https://github.com/brave/brave-core/pull/5229
Confirmed that if I install 1.8.x on a non-Ads region (ex. Aruba), and upgrade to 1.9.x, I get the Brave Ads have arrived notification on BAT logo as expected.
- Confirmed that if I use the --brave-ads-debug flag as noted in https://github.com/brave/brave-browser/issues/9153#issuecomment-626567087, the notification goes away after 5 minutes as noted
- Confirmed that if I do not use the --brave-ads-debug flag, the notification does not go away after 5 minutes, but does go away after 1 week (+ some time for jitter).

Verification passed on

Brave	1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/5229
Confirmed that if I install 1.8.x on a non-Ads region (ex. Aruba), and upgrade to 1.9.x, I get the Brave Ads have arrived notification on BAT logo as expected.
- Confirmed that if I use the --brave-ads-debug flag as noted in https://github.com/brave/brave-browser/issues/9153#issuecomment-626567087, the notification goes away after 5 minutes as noted
- Confirmed that if I do not use the --brave-ads-debug flag, the notification does not go away after 5 minutes, but does go away after 1 week (+ some time for jitter).