question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

removing google sign in modal from chrome://devices

See original GitHub issue

Description

We should remove the Google Sign In modal window under chrome://devices which also includes Google branding. Because this is pretty buried, I don’t think we need to fix it for 0.55.x but should remove this before releasing 1.0..

Steps to Reproduce

  1. launch b-c and load chrome://devices
  2. click on sign in and you’ll get a Google sign in modal that includes Google branding

Actual result:

screen shot 2018-09-25 at 4 07 32 pm

Expected result:

Clicking on Sign in under chrome://devices shouldn’t launch the Google modal which also includes Google branding.

Reproduces how often:

100% reproducible when going through the above STR.

Brave version (chrome://version info)

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Reproducible on current release:

Yes, currently reproducible with 0.55.6 Chromium: 70.0.3538.16 which is the current release.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
kjozwiakcommented, Sep 26, 2018

On second thought, probably a good idea to remove this sooner than later due to the Google automatically logging folks into their browser without asking issue that’s pretty hot right now.

0reactions
kjozwiakcommented, Oct 11, 2018

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
screen shot 2018-10-10 at 9 52 27 am

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux
Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Disable 'Sign in with Google Account' Pop-up on ...
Stop 'Sign in with Google Account' Pop-up · 1. Open any browser on your PC and go to the Google My Account page....
Read more >
Block or allow pop-ups in Chrome - Computer - Google Support
On your computer, open Chrome Chrome . · At the top right, click More More and then Settings. · Click Privacy and security...
Read more >
How To Completely Remove Your Google Account From A ...
In this video tutorial, I show you how to completely remove your Google Account from a computer (Or any other device ).
Read more >
How to disable Google One Tap sign-up prompts? - Super User
Users can opt out One Tap by disabling the "Google Account sign-in prompts" flag in the connected apps page. The opted-out sessions aren't ......
Read more >
How to Remove Google Account from Chrome iPhone or iPad?
Tap on currently signed-in Google Account. It will display the list of currently signed-in accounts on the chrome browser. Select the Google ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found