Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Replace the Muli font with Poppins
See original GitHub issueWe have decided to stop using Muli, which we mainly used for body content. Uses should be replaced with Poppins. When replacing, we generally have to dial down the font-weight a little (e.g. from 600 to 500).
This requires changes in brave-core and brave-ui (where there are theme variables and shared styles from components).
Places:
- Welcome
- Rewards (page, not panel)
- NTP widgets
Test Plan
- Open brave://welcome
- Verify that the font being used is Poppins not Muli, via referencing the below screenshots
- Turn on and open brave://rewards. Verify the font (for the “left” column) is correct as per the below screenshots
- Open NTP and switch to Brave Talk widget. Verify screenshots…
Screenshots (old on right, new on left)
Notes
If you really want to verify which font is being used, you can inspect the element, switch to the “computed” tab and scroll right to the bottom. DevTools will report which font is being used to actually render.
Issue Analytics
- State:
- Created a year ago
- Comments:8 (3 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@aguscruiz if the places mentioned in https://github.com/brave/brave-browser/issues/25527#issuecomment-1332776558 need to be addressed, please open a new issue for it, thanks!
No problem! Will do, here is the new issue https://github.com/brave/brave-browser/issues/27081