question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Restore all from deleted publisher doesn't restore all

See original GitHub issue

Description

Restore all doesn’t get removed after restoring all deleted sites

Steps to Reproduce

  1. Enable Rewards on 0.55.1
  2. Visit 8-10 sites so that its listed on the auto-contribute list
  3. Delete 2-3 sites from list
  4. Click on Show all to see the full list of publishers
  5. Click on Restore All from the publisher window. Removed site gets added but still shows 1 excluded site

Actual result:

restore all1

Expected result:

Restore all should not show any value for excluded list. Defeats the purpose of restore all

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes on beta
  • Does it reproduce on browser-laptop? No.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @LaurenWags @kjozwiak @NejcZdovc

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:10 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
NejcZdovccommented, Nov 4, 2018

Will close this one and let’s retest it in the latest master, where https://github.com/brave/brave-core/pull/797 will land as well

1reaction
LaurenWagscommented, Nov 1, 2018

@jasonrsadler I definitely did not click x more than once, however I just tried the steps from https://github.com/brave/brave-browser/issues/1441#issuecomment-428593480 and was unable to reproduce the issue using

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
Read more comments on GitHub >

github_iconTop Results From Across the Web

Microsoft Publisher How to Recover an unsaved document
tmp. Right click on the file name, select "Rename", and changed the extension from .tmp to .pub, and press "enter". You can try...
Read more >
Easy way to Recover Deleted Publisher File 2022
Click on the Manage Document and select Recover Unsaved Documents from the drop-down option. Now, the unsaved file folder would contain all the ......
Read more >
How to Recover Unsaved Publisher File[2021]
You can see all the deleted or lost files on the drive. Click on 'Preview' to know if that was the publisher file...
Read more >
How do I recover a Microsoft Publisher autosave file not saved
I've had files recover that have not been saved when we've had a power failure. You can test this by having a Publisher...
Read more >
How to Recover Lost Publisher File or Unsaved Microsoft ...
Another way to recover deleted Publisher Files from Autosave is through Publisher Settings. Step 1:Open Publisher and go to File > Info >...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found