question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`Save all files` button should be disabled until `Start`

See original GitHub issue

Description

Save all files button should be disabled until Start

Steps to Reproduce

  1. install 1.44.60
  2. launch Brave
  3. load https://webtorrent.io/free-torrents
  4. click on the magnet link for any of the files
  5. in the resulting WebTorrent view, look at the Save all files button

Actual result:

Save all files button is enabled, but doesn’t do anything (until after you start the torrent)

Screenshot 2022-08-24 at 3 02 08 PM

Expected result:

Save all files button should be disabled until after you’ve started the torrent

Reproduces how often:

Brave version (brave://version info)

Brave 1.44.60 Chromium: 105.0.5195.37 (Official Build) nightly (x86_64)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS macOS Version 13.0 (Build 22A5321d)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:6

github_iconTop GitHub Comments

2reactions
stephendonnercommented, Dec 3, 2022

Verified PASSED using

Brave 1.47.110 Chromium: 108.0.5359.71 (Official Build) beta (x86_64)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS macOS Version 13.1 (Build 22C5059b)

Torrent file:

default in-progress complete save all files
Screenshot 2022-12-02 at 10 36 25 PM Screenshot 2022-12-02 at 10 36 34 PM Screenshot 2022-12-02 at 10 36 44 PM Screenshot 2022-12-02 at 10 37 11 PM

Magnet link:

default in-progress complete save all files
Screenshot 2022-12-02 at 10 54 58 PM Screenshot 2022-12-02 at 10 55 05 PM Screenshot 2022-12-02 at 10 55 19 PM Screenshot 2022-12-02 at 10 56 02 PM
2reactions
panopliedcommented, Sep 5, 2022

@fallaciousreasoning unable to add you as a reviewer, but check the PR #https://github.com/brave/brave-core/pull/14977

Read more comments on GitHub >

github_iconTop Results From Across the Web

Should a Save button be disabled if there have been no ...
Yes, the save button should be disabled if there have been no changes made. It's best if the button's ...
Read more >
Keeping the submit button disabled until a change is made
I want the save button to be in a disabled state on page load, and remain that way until a change is made...
Read more >
Disable "Save" Button Until User Selects "I Agree"
So, we've to disable “Save” button until the “I Agree” check box is checked! Here is the jQuery script to achieve the same....
Read more >
"Save All" Button in VS Code is Greyed Out #127935 - GitHub
Yes/No VS Code Version: 1.57.1 OS Version: Ubuntu 20.04.2 LTS Steps to Reproduce: The "File => Save All" button in VS Code is...
Read more >
Disable/Enable Buttons in UserForms - TeachExcel.com
This disables the button from the start, and allows you to have an action enable it later. Go to the UserForm_Initialize() event and...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found