Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Security] Mitigate DNS rebinding flaw

See original GitHub issue

Mitigate the WebTorrent DNS rebinding flaw disclosed in HackerOne. Low security/privacy risk.

Original issue: https://github.com/brave/browser-laptop/issues/12616 Original Brave PR: https://github.com/brave/browser-laptop/pull/13844 Original WebTorrent PR: https://github.com/webtorrent/webtorrent/pull/1260 Fixed WebTorrent PR: https://github.com/webtorrent/webtorrent/pull/1678

The fix is already published in webtorrent@0.105.2. We should update to this version.

Issue Analytics

State:
Created 4 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

yrlioucommented, Sep 26, 2019

Talked to @GeetaSarvadnya through DM about testing on Windows, note here for future references. On Windows, we could install nmap from https://nmap.org/ncat/ which includes ncat. When testing, change to the installation folder, such as c\Program Files (x86)\Nmap, and run cat <(echo -en 'GET / HTTP/1.1\r\nHost: attacker.com\r\n\r\n') - | ./ncat.exe localhost 49976 (Replace port with the result of previous step.) This command is tested using MINGW64, might need a little tweak if you are using other tools.

1reaction

kjozwiakcommented, Sep 26, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave	0.69.126 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision	87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS	macOS Version 10.14.6 (Build 18G95)

Verified STR outlined under https://github.com/brave/brave-browser/issues/5460#issuecomment-516586163

Verification passed on

Brave	0.69.127 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision	201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS	Ubuntu 18.04 LTS

Verified STR outlined under https://github.com/brave/brave-browser/issues/5460#issuecomment-516586163

Verification passed on

Brave	0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified STR outlined under https://github.com/brave/brave-browser/issues/5460#issuecomment-516586163

Top Results From Across the Web

DNS Rebinding Attack: How Malicious Websites ... - Unit 42

DNS rebinding allows attackers to take advantage of web-based consoles to exploit internal networks by abusing the domain name system.

DNS rebinding - Wikipedia

DNS rebinding is a method of manipulating resolution of domain names that is commonly used as a form of computer attack. In this...

Practical Protection Against DNS Rebinding Attacks

A DNS rebinding attack that exploits a local service shows that the domain name is pointing to a loopback address. Similarly, if it's...

Protecting Browsers from DNS Rebinding Attacks

Firmware patches have attempted to secure routers against cross-site scripting and cross-site request forgery, in an effort to prevent recon- figuration attacks ...

Defending Networks Against DNS Rebinding Attacks - CircleID

Using DNS rebinding, an attacker can circumvent firewalls to spider corporate Intranets, exfiltrate sensitive documents, and compromise unpatched internal ...