Shields v2 doesn't show up when Brave Rewards icon is disabled
See original GitHub issueDescription
Shields v2 should show up even if Brave Rewards icon is turned off.
Steps to Reproduce
- Open
brave://settings/appearance - Disable
Show Brave Rewards icon in address bar
Actual result:


Expected result:
Shields icon must be on the address bar.
Reproduces how often:
Easily
Brave version (brave://version info)
1.38.60 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
Windows 10 Version 21H2 (Build 19044.1586)
Version/Channel Information:
- Can you reproduce this issue with the current release? n/a
- Can you reproduce this issue with the beta channel? n/a
- Can you reproduce this issue with the nightly channel? Yes
Other Additional Information:
- Does the issue resolve itself when disabling Brave Shields? n/a
- Does the issue resolve itself when disabling Brave Rewards? n/a
- Is the issue reproducible on the latest version of Chrome? n/a
Miscellaneous Information:
Issue Analytics
- State:
- Created a year ago
- Reactions:3
- Comments:7 (2 by maintainers)
Top Results From Across the Web
Shield Icon no longer appearing on latest beta
Shields v2 doesn't show up when Brave Rewards icon is disabled ... This topic was automatically closed 30 days after the last reply....
Read more >Problem, Brave shields they are disabled by default
In this update to version 1.38, my Brave shields they are disabled on any site I access, I had previously a general cleaning...
Read more >Brave Rewards icon is missing from the top bar
Description of the issue: The BAT icon from my topbar just disappeared. As far as I know, it should be there right next...
Read more >Brave Shields Not Working? - Desktop Support
I tried closing Brave completely and opening it back up. Same issue. Shields work on some sites, not others, including sites with known...
Read more >CBS Shows Not Playing In Brave - Desktop Support
no unfortunately not, and a major annoyance once you leave a site and go back to it shield is back on for that...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

Removing
QA Pass-Win64as this will need to be rechecked via1.38.xonce uplifted via https://github.com/brave/brave-core/pull/12754. @MadhaviSeelam thanks for running through the above but this one is pending to be uplifted into1.38.xas per https://github.com/brave/brave-core/pull/12754. Our process is to verify the PR on Nightly which @stephendonner did via https://github.com/brave/brave-core/pull/12742#issuecomment-1081221126 before uplifting.Verified
Passedusingbrave://settings/appearanceShow Brave Rewards icon in address barShieldsstill displayed in the URL bar whenRewardsicon is disabled