Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`Shields v2`: Some texts need a change

See original GitHub issue

Description

Just a typo and inconsistency.

Steps to Reproduce

Install Brave Nightly.
Enable brave://flags/#brave-shields-v2 -> Relaunch.
Open a random website, for example brave.com.
Open the Shields panel via the Shields icon.
Click on Advanced Controls.

Actual result:

muOaXS6aXe

Expected result:

Note: this may reduce Brave privacy protections. -> Note: this may reduce Brave's privacy protections.
Filter Lists and Global defaults -> (Filter lists and Global defaults) or (Filter Lists and Global Defaults) so there is consistency.

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.38.32 Chromium: 99.0.4844.51 (Official Build) nightly (64-bit)
Revision	d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS	Windows 7 Service Pack 1 (Build 7601)

</body> </html>

Issue Analytics

State:
Created 2 years ago
Comments:8 (3 by maintainers)

Top GitHub Comments

1reaction

Tonevcommented, Mar 31, 2022

Sorry for getting late to you, @stephendonner, somehow missed your email. There was no need for a new ticket as @nullhook addressed the matter in another pull request (https://github.com/brave/brave-core/pull/12775), just at a later point so your testing wasn’t able to catch it.

Brave	1.39.22 Chromium: 100.0.4896.60 (Official Build) nightly (64-bit)
Revision	6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS	Windows 7 Service Pack 1 (Build 7601)

</body> </html>

0reactions

Tonevcommented, Apr 2, 2022

@MadhaviSeelam

Thanks for telling me, but I’m afraid I won’t be able to do anything about it. If folks keep updating the designs, and the designs don’t future the changes from this ticket, I’m afraid it would be a lost cause - someone will update through a PR, and then someone else’s PR that updates the designs will erase the previous PR’s changes.

CC: @rebron @stephendonner @aguscruiz @nullhook for thoughts on the matter, please!