Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Should use serial comma in pre-filled Brave News `Discover` search text

See original GitHub issue

Description

Should use serial comma in pre-filled Brave NewsDiscover search text.

(Yeah, I know.)

Steps to Reproduce

install 1.47.14
launch Brave
open brave://flags
set brave://flags/#brave-news-v2 to Enabled
click Relaunch
open a new-tab page
click Customize
click Turn on Brave News
beneath the Discover heading, read the pre-filled Search for news, site, topic or RSS feed line

Actual result:

Expected result:

Search for news, site, topic, or RSS feed

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.47.14 Chromium: 107.0.5304.62 (Official Build) nightly (x86_64)
Revision	1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS	macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? `Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning @petemill @rmcfadden3

Issue Analytics

State:
Created a year ago
Comments:6 (2 by maintainers)

Top GitHub Comments

3reactions

petemillcommented, Oct 25, 2022

That’s fine, but only if we call it the oxford comma

2reactions

mattmcalistercommented, Oct 31, 2022

also it doesn’t search for news. it should read…

Search for site, topic, or RSS feed

Top Results From Across the Web

The Chicago Manual of Style Online: Search Results

The way I like to look at the serial comma is this: 1. It's sometimes necessary to include the serial comma to prevent...

can you turn off the ability to tear off tabs and how would i run ...

"Shields" text in Trackers and ads panel is not translated #22550 ... Should use serial comma in pre-filled Brave News Discover search text...

Serial Commas and Serial Semicolons | MLA Style Center

With the exception of newspapers, most publications use the serial comma, because it helps writers avoid ambiguity. Who would object to ...

Copywriting 101: Why So Serial? - Corporate Three Design

Most loyalists of the AP's guidelines would argue that including an additional comma before the conjunction “and” is unnecessary and also terribly redundant....

Serial Comma Vs. Oxford Comma: A Helpful Guide

There is no hard and fast rule on when to use a serial comma or Oxford comma and when not to. Some publications...