question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Site-icon's focus ring is too tall, and is clipped beneath the site icon below it

See original GitHub issue

Description

Focus ring is too tall, and is clipped beneath the site icon below it

Steps to Reproduce

  1. switch to the Favorites view in Top Sites via either the context-menu item or via Customize -> Top Sites -> Favorites
  2. add > 6 favorites (up to 12)
  3. start pressing Tab on the first row, and notice the focus ring

Actual result:

The focus ring extends beneath the next site’s favicon, and looks awkward due to being clipped

Screen Shot 2021-03-17 at 7 29 06 PM

Expected result:

No clipping into the next site’s favicon; in Figma, the focus ring looks to merely comprise the favicon/tile, not the accompanying site text

Screen Shot 2021-03-17 at 7 37 29 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.24.2 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc: @karenkliu @rebron @simonhong @bsclifton

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
GeetaSarvadnyacommented, Mar 18, 2021

1.21.x - Not Reproducible 1.22.x - Not Reproducible 1.23.x - Reproducible 1.24.x - Reproducible

0reactions
stephendonnercommented, Mar 25, 2021

Verified FIXED using

Brave 1.24.26 Chromium: 90.0.4430.30 (Official Build) nightly (x86_64)
Revision 5674335ff855e43f3bccf8cfc29a779bdf0d067f-refs/branch-heads/4430@{#532}
OS macOS Version 11.2.3 (Build 20D91)

The focus ring is now back to spec.

Screen Shot 2021-03-25 at 9 27 51 AM Screen Shot 2021-03-25 at 9 28 00 AM
Read more comments on GitHub >

github_iconTop Results From Across the Web

How To Design Useful and Usable Focus Indicators
New from Deque: Learn how to design effective focus indicators that are accessible and comply with WCAG standards for website a11y.
Read more >
Buttons - Menus and actions - Human Interface Guidelines
A button always includes a text label or a symbol (or interface icon) — and ... usually within or beneath it — so...
Read more >
How-To Create Desktop Shortcut Icons Directly ... - YouTube
Creating desktop shortcuts for a website is a great way to keep your favorite websites organized. In this video we walk you through...
Read more >
focus-visible - CSS: Cascading Style Sheets - MDN Web Docs
The :focus-visible pseudo-class applies while an element matches the :focus ... (Many browsers show a "focus ring" by default in this case.)
Read more >
Links - Usability & Web Accessibility - Yale University
While screen readers can read a full page to a user, screen reader users ... For such users, it is very important for...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found