Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"Start video call" button in card should link to talk.brave.com/widget

See original GitHub issue

Description

Start video call button in card should link to talk.brave.com/widget

Steps to Reproduce

new profile
launch Brave
load a new-tab page
click on Edit cards
add the Brave Together (to be renamed to Brave Talk) card
open the Network panel in Developer Tools
click on the Start video call button
look at the URLs/redirects

Actual result:

button	URL

Expected result:

Should go to talk.brave.com/widget without any loads to/redirects from together.brave.com

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.29.20 Chromium: 92.0.4515.107 (Official Build) nightly (x86_64)
Revision	87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS	macOS Version 12.0 (Build 21A5284e)

cc @mattmcalister @rebron @bsclifton

Issue Analytics

State:
Created 2 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

bscliftoncommented, Aug 2, 2021

@stephendonner done - https://github.com/brave/brave-core/pull/9608

0reactions

GeetaSarvadnyacommented, Aug 10, 2021

Verification passed on

Brave | 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1110)

Verified the STR from the description, additional testing is covered in https://github.com/brave/brave-browser/issues/17147#issuecomment-895836064
Confirmed click on Start video call in NTP widgets redirects to https://talk.brave.com/widget
Confirmed click on Start video call in https://talk.brave.com/widget initiates the call successfully