question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support building with different channels w/ different branding

See original GitHub issue

You can find icon resources here: https://github.com/brave/muon/tree/master/app/resources

Anthony started things here, and apparently it works for macOS. https://github.com/brave/brave-browser/tree/multi-channel https://github.com/brave/brave-core/tree/multi-channel

So still remaining is Linux and Windows.

You can see where we have different profile directories for each OS here: https://github.com/brave/brave-core/pull/46 https://github.com/brave/brave-core/pull/59 This doc might be helpful: https://chromium.googlesource.com/chromium/src/+/master/docs/user_data_dir.md

We want to support 4 channels: release, beta, developer, and canary

User directory

For official build

  • ~/Library/Application Support/BraveSoftware/Brave-Browser-Dev/Default for dev channel
  • ~/Library/Application Support/BraveSoftware/Brave-Browser-Beta/Default for beta channel
  • ~/Library/Application Support/BraveSoftware/Brave-Browser-Canary/Default for canary channel
  • ~/Library/Application Support/BraveSoftware/Brave-Browser/Default for release channel

For unofficial build

  • ~/Library/Application Support/BraveSoftware/Brave-Browser-Development/Default for all channel

TODOs

  • channel option for build command (brave-browser)
  • user dir support (brave-core)
    • MacOS
    • Windows
    • Linux
  • install dir
    • MacOS
    • Windows
    • Linux
  • app icon (brave-core)
    • MacOS
    • Windows
    • Linux

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:2
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
bbondycommented, Mar 28, 2018

~/Library/Application Support/Brave-Browser-Dev/Default for dev channel ~/Library/Application Support/Brave-Browser-Development/Default for official_build=false builds.

0reactions
simonhongcommented, Apr 4, 2018

On windows, channel info is fetched from executables path.

void InitializeProductDetailsForPrimaryModule() {
  InstallDetails::SetForProcess(MakeProductDetails(GetCurrentProcessExePath()));
}

In the startup progress of beta, Beta is fetched from “C:\Program Files (x86)\Google\Chrome Beta\Application\chrome.exe” and appropriate InstallConstants is set as a global variable. Then, this variable is used to get various channel information on runtime.

Need to check GetDefaultUserDataDirectory() in chrome_paths_win.cc

We have copied chromium_install_modes.[h|cc] version, however, upstream version is still compiled together. install_static_util target is including upstream version and is build as a separate library. I need to fix this first.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Making Your Brand Stand Out Across Channels - Shopify
By using both channels to support your goals and your customers' needs, you can build a more relevant and memorable brand experience. While...
Read more >
The Definitive Guide to Multi-Channel Marketing | Wrike
Here are some multi-channel marketing examples that illustrate this idea: Google Ads are used to promote various products and services. These ...
Read more >
The Top Marketing Channels, And How They'll Change in ...
Using different channels creates multiple points of contact, nurturing your leads and increasing conversions.
Read more >
Brand Awareness: 6 Tips for Creating a Powerful Brand Strategy
If your brand strategy is different on different channels, people won't be able to decode what your brand is all about.
Read more >
12 Key Digital Marketing Channels & How to Use Them
Companies use various digital marketing channels to connect with current and ... Content is unique in that it helps you to build curiosity, ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found