Support for custom filter lists in Shields

Description

Some popular adblocking extensions help users create filter lists to supplement the default ones. This can for example allow someone to hide parts of a website that are not deemed useful or desirable but that would otherwise be out of scope for EasyList/EasyPrivacy.

This is an advanced use case for sure, and we should focus on shipping the best default-on adblocker, but I thought I’d mention it since it might allow some users to avoid installing an additional extension and have everything they need built-in.

Designs

Add functionality to subscribe to filter lists via URL on brave://adblock

Insert the following designs below “Additional Filters” and above “Custom Filters”:

After the user clicks on “Add filter list via URL”, a form field appears with “Submit” and “Cancel”:

Built-in error validation for the field specifies entry must start with https://

Submitting the filter list URL will add the filter list to a table with a toggle to enable/disable and available actions:

• Update now
• View website
• View source
• Unsubscribe

If the user enters a filter list that is invalid or unavailable, the table entry shows the filter as Download failure with no toggle available:

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/Desktop-Settings?node-id=49%3A2359

[Furax-31]

This feature is still not available?

[antonok-edm]

@GeetaSarvadnya to be honest, I’m not sure what timezone that’s supposed to be - I would have assumed UTC? At any rate, it’s the default serialization for the base::Time structure in Chromium, and I wouldn’t worry too much about that being incorrect. Should be fine as long as it’s within the right day and consistent relative to other downloads and across browser restarts.

I think it can be revisited when the rest of the brave://adblock UI gets redesigned. I’d consider this a UI/UX concern, of which the page doesn’t have much of to begin with 😂