Sync warn modal needs refactoring
See original GitHub issueDescription
Sync warn modal needs refactoring
Steps to Reproduce
- Enable sync on beta with
--enable-brave-sync
- Click on
I have an existing Sync code
- Click
Setup Sync
without entering any code or device name, shows the warn message which is just plain text (see screenshot)
Actual result:
Expected result:
Should show proper error message which is refactored
Reproduces how often:
Easy
Brave version (brave://version info)
Brave | 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit) |
---|---|
Revision | c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427} |
OS | All |
Reproducible on current release:
- Does it reproduce on brave-browser dev/beta builds? Yes on beta build
Website problems only:
- Does the issue resolve itself when disabling Brave Shields?
- Is the issue reproducible on the latest version of Chrome?
Additional Information
#2126 also needs a warning similar to this if a device name is mandatory @rebron @bbondy @kjozwiak added to 1.x backlog as this is just a refactor which isn’t priority but if needed please add it to 0.57.x milestone.
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
multiple modals not working #171 - GitHub
I switched from react-native's default Modal to react-native-modal ... It's also likely going to require some refactoring since you're using ...
Read more >Android: How to get a modal dialog or similar modal behavior?
Build one worker thread, and use thread synchronization. However, it's a huge refactoring job for my app, now I have a single main...
Read more >Refactoring node.js (Part 1) - DEV Community
Here's an example of async and sync code to read a file ... like readFileSync ) looks cleaner, because it doesn't require a...
Read more >1. Refactoring - Refactoring at Scale [Book] - O'Reilly
We need to be mindful of how our refactoring efforts fit into these cycles, ... given a reasonable set of requirements; however, I...
Read more >Publishing changes from within view updates is not ... - YouTube
... THE PROBLEM 03:52 PUBLISHED IN SWIFTUI 4 04:54 FIX THE PURPLE WARNING 06:04 USING PUBLISHED WITH STATE 09:45 REFACTORING THE CODE 13:23 ......
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
ya correct
Verification passed on
Verification passed on
Verified passed with