question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Sync warn modal needs refactoring

See original GitHub issue

Description

Sync warn modal needs refactoring

Steps to Reproduce

  1. Enable sync on beta with --enable-brave-sync
  2. Click on I have an existing Sync code
  3. Click Setup Sync without entering any code or device name, shows the warn message which is just plain text (see screenshot)

Actual result:

image image

Expected result:

Should show proper error message which is refactored

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit)
Revision c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes on beta build

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

#2126 also needs a warning similar to this if a device name is mandatory @rebron @bbondy @kjozwiak added to 1.x backlog as this is just a refactor which isn’t priority but if needed please add it to 0.57.x milestone.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
cezaraugustocommented, Nov 16, 2018

ya correct

0reactions
srirambvcommented, Dec 14, 2018

Verification passed on

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

image

Verification passed on

Brave 0.59.8 Chromium: 71.0.3578.98 (Official Build) beta (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows

image

Verified passed with

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
Read more comments on GitHub >

github_iconTop Results From Across the Web

multiple modals not working #171 - GitHub
I switched from react-native's default Modal to react-native-modal ... It's also likely going to require some refactoring since you're using ...
Read more >
Android: How to get a modal dialog or similar modal behavior?
Build one worker thread, and use thread synchronization. However, it's a huge refactoring job for my app, now I have a single main...
Read more >
Refactoring node.js (Part 1) - DEV Community ‍ ‍
Here's an example of async and sync code to read a file ... like readFileSync ) looks cleaner, because it doesn't require a...
Read more >
1. Refactoring - Refactoring at Scale [Book] - O'Reilly
We need to be mindful of how our refactoring efforts fit into these cycles, ... given a reasonable set of requirements; however, I...
Read more >
Publishing changes from within view updates is not ... - YouTube
... THE PROBLEM 03:52 PUBLISHED IN SWIFTUI 4 04:54 FIX THE PURPLE WARNING 06:04 USING PUBLISHED WITH STATE 09:45 REFACTORING THE CODE 13:23 ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found