Tabs crash after restart and console throws error about ads service already running

Description

Tabs crash after restart and console throws error about ads service already running

Steps to Reproduce

1. Wait for browser update button to show up
2. Quit browser and restart
3. Console logs error about ads service, all open tabs crash
4. Opening a new tab and trying to load any chrome:// page doesn’t work
5. Quit and relaunch browser, loads all tabs correctly and no ads error in console

Actual result:

[9268:259:0629/015257.599313:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.599488:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.599628:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.599774:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.599826:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.599835:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.599959:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.600000:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.600223:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.600294:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.600366:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.600403:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.600518:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.600572:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.600702:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.600722:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.600883:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.600949:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.601092:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.601176:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.601359:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress
 [9268:259:0629/015257.601386:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.601524:VERBOSE1:ads_service_impl.cc(769)] Restarting ads service
 [9268:259:0629/015257.601643:VERBOSE1:ads_service_impl.cc(922)] Do not proceed with current ads service init as another ads service start is in progress

https://bravesoftware.slack.com/archives/C01EVLWS8R5/p1656482305536969?thread_ts=1656482305.536969&cid=C01EVLWS8R5

Expected result:

No tab crash or logs any error

Reproduces how often:

Intermittent

Brave version (brave://version info)

Brave	1.42.39 Chromium: 103.0.5060.66 (Official Build) nightly (arm64)
Revision	20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS	macOS Version 12.4 (Build 21F79)

Version/Channel Information:

• Can you reproduce this issue with the current release? Not sure
• Can you reproduce this issue with the beta channel? Not sure
• Can you reproduce this issue with the nightly channel? Yes observed only on nightly

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @iefremov @tmancey @bridiver @rebron

[tmancey]

@srirambv if you could enable verbose logging and send over logs when the crash occurs again. How many tabs do you have open? Are you running multiple user profiles? Thanks

[tmancey]

@srirambv we have refactored the ads service startup code, so could you please let us know if you experience the issue again by reopening this issue?