question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Test that Brave News Display Ads has OS-level targeting

See original GitHub issue

Description

Test that on specific creatives (via creativeSet targeting) only render on their respectively targeted operating system

Steps to Reproduce

For each operating system:

  1. Launch Brave Browser with staging catalog
  2. Opt in to Brave News
  3. Scroll until you see the Brave News Display Ad (Hamster)
  4. Confirm that this Ad is of the correct creativeInstanceId (see below for table of creativeInstance/os relationship). The Ad description text will also indicate os-target. ex. Fung Brave News Inline Display Ad - mac/linux
  5. Confirm that you do not see Ads with creativeInstanceIds for other os-targets

Actual result:

Expected result:

Brave News Display Ads should only render ads with creativeInstanceId (description text as proxy) for it’s targeted operating system.

Reproduces how often:

Should be easy to reproduce. If not, reach out to @iambrianfung and he can adjust the frequency capping.

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

All Channels

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

          creativeInstanceId          |            creativeSetId             |  name   
--------------------------------------+--------------------------------------+---------
 e4958d00-e35c-4134-a408-1fbcf274d5ae | 8b848823-c47f-43de-a753-2efa8dea6863 | macos
 e4958d00-e35c-4134-a408-1fbcf274d5ae | 8b848823-c47f-43de-a753-2efa8dea6863 | linux
 cbe9f40d-257f-429c-939c-39f3d05a0372 | 59ae2407-51ae-48f6-9d67-6ae234319181 | ios
 cbe9f40d-257f-429c-939c-39f3d05a0372 | 59ae2407-51ae-48f6-9d67-6ae234319181 | android
 fe7e925e-5490-431b-b788-4c64f5543e0d | f1886272-e83d-4efb-b53c-72a1c79ae0b3 | windows

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7

github_iconTop GitHub Comments

1reaction
tmanceycommented, Mar 10, 2022

@btlechowski agreed as it works off same code base as all other creatives. Thanks

0reactions
btlechowskicommented, Mar 10, 2022

Verification passed on

Brave 1.37.86 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS

catalog 19386.txt

From 3 ads, only mac/linux ad was chosen and shown

[5870:5870:0310/213907.137752:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[5870:5870:0310/213907.138921:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[5870:5870:0310/213907.143312:VERBOSE2:ad_priority.h(33)] 1 ads with a priority of 1 in bucket 1
[5870:5870:0310/213907.147835:VERBOSE1:eligible_inline_content_ads_v1.cc(195)] 1 eligible ads out of 1 ads for untargeted segment
[5870:5870:0310/213907.148634:VERBOSE1:inline_content_ad_serving.cc(87)] Found 1 eligible ads
[5870:5870:0310/213907.148724:VERBOSE1:inline_content_ad_serving.cc(130)] Serving inline content ad:
  uuid: 8d2829ac-ae2f-476b-87c8-1532f2606ba7
  creativeInstanceId: e4958d00-e35c-4134-a408-1fbcf274d5ae
  creativeSetId: 8b848823-c47f-43de-a753-2efa8dea6863
  campaignId: 07de7f05-ab32-4af0-a350-a1bce4427eac
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: untargeted
  title: mac/linux
  description: Fung Brave News Inline Display Ad - mac/linux
  imageUrl: https://pcdn.brave.com/brave-ads/468beb93-2458-5d3e-8d7b-bc1f387d2e9b.webp.pad
  dimensions: 900x750
  ctaText: mac/linux
  targetUrl: https://brave.com/careers
[5870:5870:0310/213907.149196:VERBOSE1:inline_content_ad_serving.cc(99)] Served inline content ad
[5870:5870:0310/213907.150487:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid 8d2829ac-ae2f-476b-87c8-1532f2606ba7 and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae
[5870:5870:0310/213907.166787:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event

Ads from windows and android/ios are not shown

[5870:5870:0310/215439.203217:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[5870:5870:0310/215439.204646:VERBOSE1:eligible_inline_content_ads_v1.cc(174)] Get eligible ads for untargeted segment
[5870:5870:0310/215439.207949:VERBOSE2:exclusion_rules_base.cc(127)] creativeInstanceId e4958d00-e35c-4134-a408-1fbcf274d5ae has exceeded the perHour frequency cap
[5870:5870:0310/215439.208098:VERBOSE1:seen_advertisers.h(30)] All inline_content_ad advertisers have been shown, so round robin
[5870:5870:0310/215439.208119:VERBOSE1:client.cc(446)] Resetting seen inline_content_ad advertisers
[5870:5870:0310/215439.208205:VERBOSE1:seen_ads.h(30)] All inline_content_ad ads have been shown, so round robin
[5870:5870:0310/215439.209216:VERBOSE1:client.cc(410)] Resetting seen inline_content_ads
[5870:5870:0310/215439.209675:VERBOSE1:eligible_inline_content_ads_v1.cc(191)] No eligible ads out of 1 ads for untargeted segment
[5870:5870:0310/215439.209939:VERBOSE1:inline_content_ad_serving.cc(82)] Inline content ad not served: No eligible ads found

Read more comments on GitHub >

github_iconTop Results From Across the Web

Brave Ads FAQ - Brave Help Center
Below is a list of commonly asked questions related to the Brave ads platform. How are “Brave Ads” different from ads I see...
Read more >
Major changes to the digital ads landscape | Brave Browser
The Brave Browser blocks third-party trackers, cookies, and ads by default—helping privacy-conscious users (who are becoming the norm) become ...
Read more >
Ad formats | Brave Browser
Brave News is a private, customizable news feed that appears in every new tab page of the Brave browser. This news feed can...
Read more >
Google ads alternatives - Brave Browser
The Brave Ads server creates a catalog of ads and targeting parameters, which is downloaded to the Brave browser on a user's device....
Read more >
Brave News Ad Unit
Both Brave News ad units are engineered for viewability. Viewable Inventory. • In addition to whether the ad was viewed, Brave provides a...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found