Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

text update needed on Dashboard Settings

See original GitHub issue

Description

Per the spec for SNTP, Show Background Image should be updated to Show Background Images.

Steps to Reproduce

Clean profile
Enable SNTP from flags, relaunch
Open Dashboard Settings on NTP

Actual result:

Expected result:

Should say Show Background Images

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

Can you reproduce this issue with the current release?
Can you reproduce this issue with the beta channel?
Can you reproduce this issue with the dev channel?
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @petemill

Issue Analytics

State:
Created 4 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

0xedwardcommented, May 22, 2020

Hi @bsclifton, this is my first time opening a PR here! Please let me know if there’s anything I should change 😄

0reactions

kjozwiakcommented, Sep 21, 2020

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.15.55 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

ensured that Customize --> Background Images under NTP displays Show Background Images when enabled & disabled
double checked and ensured that brave://settings/newTab displays the correct strings

Dashboard Settings	brave://settings

Verification passed on

Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

ensured that Customize --> Background Images under NTP displays Show Background Images when enabled & disabled
double checked and ensured that brave://settings/newTab displays the correct strings

Dashboard Settings	brave://settings

Verification passed on

Brave	1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision	ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS	Ubuntu 18.04 LTS

ensured that Customize --> Background Images under NTP displays Show Background Images when enabled & disabled
double checked and ensured that brave://settings/newTab displays the correct strings

Dashboard Settings	brave://settings

Top Results From Across the Web

Change settings in CarPlay - Apple Support

Open Settings in CarPlay using your vehicle's built-in controls. Note: If you're viewing CarPlay Dashboard and Settings doesn't appear in the recent apps...

Add or remove a text widget from a CloudWatch dashboard

Hover over the upper-right corner of the text block and choose Widget actions. Then, choose Edit. Update the text as needed and choose...

Dashboard Settings (EX) - Qualtrics

Enter the link text under Label and the website under URL. Question mark button opens to have an option for qualtrics support and...

Update Fields from the Report Run Page with Inline Editing ...

You're now set to go. Open a report and hover over the text, numeric, or checkbox field that you want to edit.

How to build Interactive Excel Dashboards that Update with ...

Download file used in the video with step by step instructions and links to more tutorials: ...