Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

There appear to be dead links in the brave/brave-core PR template

See original GitHub issue

Description

When making a pull request in brave/brave-core, some links are dead. Specifically, these two checkboxes:

I confirm that no security/privacy review is needed, or that I have requested one
A security review is not needed, or a link to one is included in the PR description

These links go to brave/handbook and brave/security respectively, both of which do not exist, or at the very least are not public repositories.

If they don’t exist, then this has gone unnoticed for at least 2 months. If they’re not public, this might be a bit confusing for people who are making pull requests and are not a part of the team.

Issue Analytics

State:
Created 2 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

3reactions

fmariercommented, Jun 4, 2021

Apologies for the delay. I’ve just moved this info to the public wiki: https://github.com/brave/brave-browser/wiki/Security-reviews

The links in the PR template should be working now.

1reaction

jbmaginationcommented, Jun 4, 2021

No worries about the delay!

Yes, your PR resolves this issue in brave/brave-browser, thank you! Will make a matching PR in brave/brave-core as this exists there as well

Top Results From Across the Web

Creating a pull request template for your repository

When you add a pull request template to your repository, project contributors will automatically see the template's contents in the pull request body....

Template:Dead link - LNF Wiki

Editors occasionally encounter dead links either within a paragraph or a reference citation. Before considering whether to use the {{dead link}} template it...

Template:Dead link – Travel guide at Wikivoyage

This template is used by Wrh2Bot to flag links that are invalid, making them easier to find and update. Using {{Dead link}} will...

Broken Link Email Template Which Gets Results [Tried & Tested]

In this post we'll share the proven tried and tested broken link email template which actually gets results and links in 2021.

GitHub pull request template - Axolo

Below, there are 6 pull request templates we recommend you to test. ... Describe your changes ## Issue ticket number and link ##...